Date: Wed, 12 Feb 2003 13:21:13 +1100 From: Tim Robbins <tjr@FreeBSD.org> To: Sean Chittenden <seanc@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/games/random Makefile random.6 random.c randomize_fd.c randomize_fd.h Message-ID: <20030212132113.A99070@dilbert.robbins.dropbear.id.au> In-Reply-To: <200302111932.h1BJWIqU016787@repoman.freebsd.org>; from seanc@FreeBSD.org on Tue, Feb 11, 2003 at 11:32:18AM -0800 References: <200302111932.h1BJWIqU016787@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 11, 2003 at 11:32:18AM -0800, Sean Chittenden wrote: > seanc 2003/02/11 11:32:18 PST > > Modified files: > games/random Makefile random.6 random.c > Added files: > games/random randomize_fd.c randomize_fd.h > Log: > Update random(6) to have the ability to randomize a file/stdin based > off of lines or words. See the man page for details. > > Reviewed by: markm > MFC after: 3 days Please fix the style bugs before MFCing it. Also fix randomize_fd() so that it properly handles the case where read() returns less than the amount of data that was requested so that it can work on FIFOs, character devices, sockets, etc. This looks suspiscious too and will mysteriously break if another option is implemented that takes an argument: 151 if ((fd = open(filename, O_RDONLY, 0)) < 0) 152 err(1, "%s", optarg); Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030212132113.A99070>