From owner-freebsd-fs@FreeBSD.ORG  Sat Nov 19 03:30:11 2011
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29530106566C
	for <freebsd-fs@hub.freebsd.org>; Sat, 19 Nov 2011 03:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 18D638FC08
	for <freebsd-fs@hub.freebsd.org>; Sat, 19 Nov 2011 03:30:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAJ3UA1S047291
	for <freebsd-fs@freefall.freebsd.org>; Sat, 19 Nov 2011 03:30:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAJ3UAUM047286;
	Sat, 19 Nov 2011 03:30:10 GMT (envelope-from gnats)
Date: Sat, 19 Nov 2011 03:30:10 GMT
Message-Id: <201111190330.pAJ3UAUM047286@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/153847: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Nov 2011 03:30:11 -0000

The following reply was made to PR kern/153847; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/153847: commit references a PR
Date: Sat, 19 Nov 2011 03:20:28 +0000 (UTC)

 Author: rmacklem
 Date: Sat Nov 19 03:20:15 2011
 New Revision: 227690
 URL: http://svn.freebsd.org/changeset/base/227690
 
 Log:
   The old NFS client will crash due to the reply being m_freem()'d
   twice if the server bogusly returns an error with the NFSERR_RETERR
   bit (bit 31) set. No actual NFS error has this bit set, but it seems
   that amd will sometimes do this. This patch makes sure the NFSERR_RETERR
   bit is cleared to avoid a crash.
   
   PR:		kern/153847
   MFC after:	2 weeks
 
 Modified:
   head/sys/nfsclient/nfs_krpc.c
 
 Modified: head/sys/nfsclient/nfs_krpc.c
 ==============================================================================
 --- head/sys/nfsclient/nfs_krpc.c	Sat Nov 19 00:20:28 2011	(r227689)
 +++ head/sys/nfsclient/nfs_krpc.c	Sat Nov 19 03:20:15 2011	(r227690)
 @@ -540,6 +540,11 @@ tryagain:
  				    hz);
  			goto tryagain;
  		}
 +		/*
 +		 * Make sure NFSERR_RETERR isn't bogusly set by a server
 +		 * such as amd. (No actual NFS error has bit 31 set.)
 +		 */
 +		error &= ~NFSERR_RETERR;
  
  		/*
  		 * If the File Handle was stale, invalidate the lookup
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"