From owner-freebsd-stable@FreeBSD.ORG Tue Jul 8 13:36:03 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from hub.FreeBSD.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E20449CC; Tue, 8 Jul 2014 13:36:02 +0000 (UTC) Date: Tue, 8 Jul 2014 09:35:59 -0400 From: Glen Barber To: =?iso-8859-1?Q?Jos=E9_Mar=EDa?= Alcaide Subject: Re: 9-STABLE nfsd(8) does not auto-tune number of threads (error in the 9.3 Release Notes!) Message-ID: <20140708133559.GF1216@hub.FreeBSD.org> References: <9E25E155-8236-409D-9A8F-E4A7EF609A9E@we.lc.ehu.es> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3y/CVJp2vtgPOhvS" Content-Disposition: inline In-Reply-To: <9E25E155-8236-409D-9A8F-E4A7EF609A9E@we.lc.ehu.es> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Rick Macklem , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jul 2014 13:36:03 -0000 --3y/CVJp2vtgPOhvS Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 08, 2014 at 03:06:38PM +0200, Jos=E9 Mar=EDa Alcaide wrote: > One of the 9.3-RELEASE Release Notes (userland changes) states that: >=20 > "The default number of nfsd(8) threads has been increased from 4 to (8 * = N), where N is the number of CPUs as reported by sysctl -n hw.ncpu. [r26212= 4]" >=20 > Indeed, revision r262124 (http://svnweb.freebsd.org/base?view=3Drevision&= revision=3D262124) removes the "-n 4" option from nfs_server_flags in /etc/= defaults/rc.conf. >=20 > The change is based on the premise that nfsd(8) auto-tunes the number of = threads as (8 * hw.ncpu). That auto-tuning was introduced in HEAD revision = r243637 of nfsd.c (http://svnweb.freebsd.org/base?view=3Drevision&revision= =3D243637), but it has not been MFC'd to 9-STABLE yet, so that release note= *is not true*. >=20 > I think that r262124 should be reverted, also removing the release note m= entioned above; or alternatively bring HEAD's nfsd.c on sync with 9-STABLE = (probably a bad idea just before 9.3-RELEASE). >=20 Reverting r262124 is also not an option at this point of the release cycle. Rick, do you have any reservations to issuing an errata notice for this after the release? Glen --3y/CVJp2vtgPOhvS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJTu/O/AAoJELls3eqvi17QFgwP/A8KPVfiZ2snawP4Ivqo8Xwq R3of7paptIBS7oKeelDHkVBbnBTL7/mItU5kcl/uZMQkzxQrRlLDNwXy8s9RCRVX /xVFA4c0UY5F81nPaH49pgXvui5jmTD7zoS5GjMCyXJ2v1TRs6Rf/1pOWCfJmyIO EwJZ9qykHBA1HZy9hsvYr5OJ3b5s/Oyf8T/BAnPpXndIKl81/VSVa2oDtY8bfaKL 3PvDbStdWnMqNxOh3croAyOTKM7nItfwDfpZzE3XnpZC5kv5hzyVo9Ao2RhxwhAy rbKUwnB3EZeFvI3eYVTQ2677zoFbE69uG6SsC/dX85kKnoWUJDwMhQ/3OvRPLbVd 1+zQ7VRq3cQsNAPxQFEVwzIXaalU6RyatNC8DM/Uv8dbbFxS7gG0PQSz3dQjjLvk txHOfEXYNUyQYaWgg8qelTt+kODFiDcn+H8OlFGPpyfToe+nuU6sOgleo3FVViZk 5Yn6j8PDHLrVlOcGBojphewlJlBsGxuZ3BK3eUjdZ/fLRZirKcWQyjzKs8Tktnbo C5Ou6ZC/bm8JgG2lKDirNrU1tVQPKClc2QOP6RjZTx2Ry5nqTnIQzRbko38Y4Z6o b8RUBf9Tr7CcIDK/tTnq3CLTKvmH3PoGJZBVt95LXftX9KCy7nYNGVESJ13c0wQH 5R9wcKpSy9zTaytAFwyz =oh8P -----END PGP SIGNATURE----- --3y/CVJp2vtgPOhvS--