From owner-cvs-all  Tue Jan 29 19:37:36 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx41.tiki.ne.jp (mx41.tiki.ne.jp [202.214.149.76])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1597737B404; Tue, 29 Jan 2002 19:37:26 -0800 (PST)
Received: from excalibur.nobutaka.com (pl953.nas921.m-hiroshima.nttpc.ne.jp [61.197.76.185])
	by mx41.tiki.ne.jp (8.9.3/3.7W) with ESMTP id MAA28120;
	Wed, 30 Jan 2002 12:37:19 +0900 (JST)
Date: Wed, 30 Jan 2002 12:37:17 +0900
Message-ID: <87sn8ocxw2.wl@excalibur.nobutaka.com>
From: MANTANI Nobutaka <nobutaka@nobutaka.com>
To: Kris Kennaway <kris@obsecurity.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/www/w3m Makefile
In-Reply-To: <20020129190211.A75663@xor.obsecurity.org>
References: <200201300255.g0U2twu76455@freefall.freebsd.org>
User-Agent: Wanderlust/2.9.5 (Unchained Melody) SEMI/1.14.3 (Ushinoya)
 FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.1
 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

At Tue, 29 Jan 2002 19:02:12 -0800,
Kris Kennaway wrote:
> 
> I don't think this can be correct: CFLAGS should always be respected,
> not hardcoded (and especially not to -O2).
> 
> I thought I sent in a patch a few weeks ago which did this for the w3m
> port.  Perhaps I forgot -- I can go and find it again if you like.

Thank you for pointing out it. How about this patch? 

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/w3m/Makefile,v
retrieving revision 1.40
diff -u -r1.40 Makefile
--- Makefile    30 Jan 2002 02:55:58 -0000      1.40
+++ Makefile    30 Jan 2002 03:29:31 -0000
@@ -28,7 +28,7 @@
                        --helpdir-ja=${PREFIX}/share/doc/ja/w3m \
                        --gc-includedir=${LOCALBASE}/include \
                        --gc-libdir=${LOCALBASE}/lib \
-                       -cflags="-O2"
+                       -cflags="${CFLAGS}"
 HOSTNAME!=     /bin/hostname
 SCRIPTS_ENV=   HOSTNAME=${HOSTNAME} WRKSRC=${WRKSRC} PREFIX=${PREFIX} \
                CC=${CC} LOCALBASE=${LOCALBASE} JAPANESE=${JAPANESE} \


--
MANTANI Nobutaka
nobutaka@FreeBSD.org, nobutaka@nobutaka.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message