Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Aug 2019 19:21:02 +0200
From:      "Carlos Jacobo Puga Medina" <cjpm@gmx.es>
To:        "Alexey Dokuchaev" <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r508723 - head/net/ocserv
Message-ID:  <trinity-7cce5a4c-b382-44b9-99bd-64f53b5fe7cc-1565630462601@3c-app-mailcom-bs15>
In-Reply-To: <20190812135241.GA26036@FreeBSD.org>
References:  <201908121052.x7CAq001072686@repo.freebsd.org> <20190812135241.GA26036@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help


=2D-
Carlos Jacobo Puga Medina <cjpm@gmx.es>


> Enviar: lunes 12 de agosto de 2019 a las 15:52
> De: "Alexey Dokuchaev" <danfe@freebsd.org>
> Para: "Carlos J. Puga Medina" <cpm@freebsd.org>
> CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-h=
ead@freebsd.org
> Asunto: Re: svn commit: r508723 - head/net/ocserv
>
> On Mon, Aug 12, 2019 at 10:52:00AM +0000, Carlos J. Puga Medina wrote:
> > New Revision: 508723
> > URL: https://svnweb.freebsd.org/changeset/ports/508723
> >
> > Log:
> >   net/ocserv: Fix typos in pkg-descr
> >
> >   PR:		239577
> >   Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
> >
> > Modified: head/net/ocserv/pkg-descr
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
> > --- head/net/ocserv/pkg-descr	Mon Aug 12 10:39:48 2019	(r508722)
> > +++ head/net/ocserv/pkg-descr	Mon Aug 12 10:52:00 2019	(r508723)
> > @@ -6,9 +6,9 @@ The OpenConnect protocol provides a dual TCP/UDP VPN c
> >  uses the standard IETF security protocols to secure it. Both IPv4
> >  and IPv6 are supported.
> >
> > -Ocserv's main features are security through provilege separation
> > +Ocserv's main features are security through privilege separation
> >  and sandboxing, accounting, and resilience due to a combined use
> > -of TCP and UDP.  Authentication occurs in an isolated security
> > +of TCP and UDP. Authentication occurs in an isolated security
>
> This was not a typo, plain text generally looks better with double
> spaces after full stop; it might not be as popular in other places/
> traditions as it is in US, but FreeBSD typically adheres to Americal
> spelling and formatting rules.
>
> Regardless of one's personal preference, touching the line merely to
> change the amount of whitespace between sentences is gratuitous (part
> of the) commmit and should've been avoided.
>

Thanks for the explanation. In fact, if you strongly disagree, please do n=
ot hesitate to revert the commit.

> ./danfe
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?trinity-7cce5a4c-b382-44b9-99bd-64f53b5fe7cc-1565630462601>