From owner-freebsd-audit Tue Jul 16 18:21:58 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5857937B400 for ; Tue, 16 Jul 2002 18:21:56 -0700 (PDT) Received: from turbine.trit.org (turbine.trit.org [63.198.170.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id D533243E31 for ; Tue, 16 Jul 2002 18:21:55 -0700 (PDT) (envelope-from dima@trit.org) Received: from turbine.trit.org (localhost [127.0.0.1]) by turbine.trit.org (Postfix) with ESMTP id CC5783E22; Wed, 17 Jul 2002 01:21:54 +0000 (UTC) To: thomas@cuivre.fr.eu.org Cc: audit@freebsd.org Subject: Re: lock(1) -v (was: VT_LOCKSWITCH) In-Reply-To: <20020715115148.A30985@melusine.cuivre.fr.eu.org>; from thomas@cuivre.fr.eu.org on "Mon, 15 Jul 2002 11:51:48 +0200" Date: Wed, 17 Jul 2002 01:21:54 +0000 From: Dima Dorfman Message-Id: <20020717012154.CC5783E22@turbine.trit.org> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Thomas Quinot wrote: > Le 2002-07-15, Dima Dorfman écrivait : > > > Anybody care to review this patch? I'd rather not commit unreviewed > > changes to a setuid root program. > > I think we'd be safer with an explicit initialization of vtyunlock. Where, why, and to what do you think it should be initialized? It's safe to assume that global variables will be initialized to 0, and it isn't used anywhere (except in tests) unless it's set to 0x2 when we lock the screen. Thanks, Dima. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message