Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Dec 2011 22:22:15 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Bernhard Froehlich <decke@FreeBSD.org>
Cc:        freebsd-emulation@FreeBSD.org, FreeBSD current <freebsd-current@FreeBSD.org>, vbox@FreeBSD.org
Subject:   Re: virtualbox r0 memory management update [Was: Freeze with 10.0 and VirtualBox {4.1.4|4.1.6|4.1.51r38464}]
Message-ID:  <4EDE7977.7010800@FreeBSD.org>
In-Reply-To: <5ca321038ae3f35c630aa29f5031d1d5@bluelife.at>
References:  <4ECF7440.4070300@entel.upc.edu> <20111126163343.GA9150@reks> "<4ED6AEFE.4010106@FreeBSD.org>" <201111301807.21351.jkim@FreeBSD.org> <60ea779052f025798cf65e18c24b7b31@bluelife.at> <47eb9f9b139dd8c59b050f1670a5f18d@bluelife.at> "<7c3c9505867f4528af276a571077b9ce@bluelife.at>" <4EDCC1C6.3040109@FreeBSD.org> <ce531a25e601ca82701d259808d7d485@bluelife.at> <4EDCCDA2.5070006@FreeBSD.org> <4EDD0644.5030902@rice.edu> <4EDD3F60.8050601@FreeBSD.org> <4EDD442C.9030406@rice.edu> <4EDD47D3.5010803@FreeBSD.org> <4EDD5CEB.1020502@rice.edu> <4EDDDB7A.4050604@FreeBSD.org> <4EDDF91F.10308@FreeBSD.org> <5ca321038ae3f35c630aa29f5031d1d5@bluelife.at>

next in thread | previous in thread | raw e-mail | index | archive | help
on 06/12/2011 20:54 Bernhard Froehlich said the following:
> On 06.12.2011 12:14, Andriy Gapon wrote:
>> Meanwhile, here is the code that I came up with:
>> http://people.freebsd.org/~avg/vbox/
>> For your convenience I have uploaded both the new file and its diff
>> against svn
>> head.  I am testing this on FreeBSD head (r228017), so far no
>> breakage observed.
>>
>> I would appreciate reviews and testing of this code.  Especially testing with
>> earlier FreeBSD releases.
> 
> VirtualBox 4.1.6 on FreeBSD 9.0-RC2/amd64 gave me:
> 
> cc -O2 -pipe -DRT_OS_FREEBSD -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DVBOX
> -DRT_WITH_VBOX -w -DVBOX_WITH_HARDENING -DVBOX_WITH_64_BITS_GUESTS
> -DRT_ARCH_AMD64 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc 
> -Iinclude -I. -Ir0drv -I. -I@ -I@/contrib/altq -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000 -fno-common 
> -fno-omit-frame-pointer  -mno-sse -mcmodel=kernel -mno-red-zone -mno-mmx
> -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector
> -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual 
> -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs
> -fdiagnostics-show-option -c
> /usr/home/decke/rpvbox/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.6_OSE/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c
> 
> /usr/home/decke/rpvbox/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.6_OSE/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:
> In function 'FreeBSDContigPhysAllocHelper':
> /usr/home/decke/rpvbox/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.6_OSE/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:212:
> error: incompatible types in initialization
> *** Error code 1
> 
> Stop in
> /usr/home/decke/rpvbox/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.6_OSE/out/freebsd.amd64/release/bin/src/vboxdrv.
> 
> *** Error code 1
> 

Could you please change that line as follows?
	vm_page_t pPage = pPages +iPage;

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EDE7977.7010800>