From owner-cvs-ports@FreeBSD.ORG Fri Feb 11 09:07:34 2005 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAAF316A4CE; Fri, 11 Feb 2005 09:07:34 +0000 (GMT) Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CAD843D41; Fri, 11 Feb 2005 09:07:33 +0000 (GMT) (envelope-from tobez@tobez.org) Received: by heechee.tobez.org (Postfix, from userid 1001) id 16150125439; Fri, 11 Feb 2005 10:07:32 +0100 (CET) Date: Fri, 11 Feb 2005 10:07:32 +0100 From: Anton Berezin To: David O'Brien Message-ID: <20050211090732.GA35843@heechee.tobez.org> Mail-Followup-To: Anton Berezin , David O'Brien , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200502020934.j129Y5qf027407@repoman.freebsd.org> <20050211082953.GA41143@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050211082953.GA41143@dragon.nuxi.com> User-Agent: Mutt/1.4.2.1i X-Powered-By: FreeBSD http://www.freebsd.org/ cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk ports/lang/perl5 Makefile ports/lang/perl5/files use.perl ports/lang/perl5.8 Makefile ports/lang/perl5.8/files use.perl X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2005 09:07:34 -0000 David, On Fri, Feb 11, 2005 at 12:29:53AM -0800, David O'Brien wrote: > On Wed, Feb 02, 2005 at 09:34:05AM +0000, Anton Berezin wrote: > > tobez 2005-02-02 09:34:05 UTC > .. > > Log: > > Update bsd.port.mk's notion of the perl version (to 5.8.6) [1]. > > Use more correct OSVERSION threshold to distinguish between > > base system perl and perl from ports - the right value is 500036 [1]. > > Also, simplify OSVERSION-related logic in lang/perl5 and lang/perl5.8. > > Now it goes as follows: > > - for lang/perl5.8, if there is perl in the base system, install > > use.perl script, use a helpful pkg-message, and do not automatically > > update symlinks; > > - for lang/perl5.8, if there is no perl in the base system, do not > > install use.perl script, and update symlinks automatically; > > I just did 'portupgrade perl-5.8.5' and wound up with > > # added by use.perl 2005-02-11 00:18:00 > PERL_VER=5.8.6 > PERL_VERSION=5.8.6 > > in my /etc/make.conf. Can we please stop spamming /etc/make.conf with > this? It is a source of very confusing bugs how it overrides > /usr/ports/Mk/bsd.*.mk for no good reason. I believe that most of your concerns which you raised back in September are addressed now, unless I misinterpreted what those concerns were. In particular, current versions of both lang/perl5 and lang/perl5.8 do not produce a stream of "added by use.perl" patches to /etc/make.conf, as it used to be, so the spamming is definitely less severe now. As for the actual patching of /etc/make.conf, I remember you've mentioned that some people doing embedded work got confused by this. Let me quote you: I know some people using FreeBSD in appliances that have been very puzzled that their perl related changes in ports/Mk/bsd.port.mk would not take affect -- because they were unknowingly being overridden by 'use.perl port's /etc/make.conf values. I don't think this should be a concern. For the majority of people the change in /etc/make.conf is needed. Those who are modifying bsd.port.mk should know what they are doing more than most. \Anton. -- The moronity of the universe is a monotonically increasing function. -- Jarkko Hietaniemi