From owner-svn-src-all@freebsd.org  Tue Oct  4 18:04:47 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0D52AF5068;
 Tue,  4 Oct 2016 18:04:47 +0000 (UTC) (envelope-from mjg@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 93656ADD;
 Tue,  4 Oct 2016 18:04:47 +0000 (UTC) (envelope-from mjg@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u94I4kDa086371;
 Tue, 4 Oct 2016 18:04:46 GMT (envelope-from mjg@FreeBSD.org)
Received: (from mjg@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u94I4khd086370;
 Tue, 4 Oct 2016 18:04:46 GMT (envelope-from mjg@FreeBSD.org)
Message-Id: <201610041804.u94I4khd086370@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org
 using -f
From: Mateusz Guzik <mjg@FreeBSD.org>
Date: Tue, 4 Oct 2016 18:04:46 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject: svn commit: r306682 - stable/11/sys/fs/nullfs
X-SVN-Group: stable-11
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2016 18:04:47 -0000

Author: mjg
Date: Tue Oct  4 18:04:46 2016
New Revision: 306682
URL: https://svnweb.freebsd.org/changeset/base/306682

Log:
  MFC r305659:
  
  nullfs: plug vnode ref leak in null_vptocnp
  
  The lower vnode is already referenced and nodeget is supposed to consume
  the reference. Thus the extra vref call was causing a leak.

Modified:
  stable/11/sys/fs/nullfs/null_vnops.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/fs/nullfs/null_vnops.c
==============================================================================
--- stable/11/sys/fs/nullfs/null_vnops.c	Tue Oct  4 17:57:30 2016	(r306681)
+++ stable/11/sys/fs/nullfs/null_vnops.c	Tue Oct  4 18:04:46 2016	(r306682)
@@ -896,7 +896,6 @@ null_vptocnp(struct vop_vptocnp_args *ap
 		vn_lock(vp, locked | LK_RETRY);
 		return (ENOENT);
 	}
-	vref(ldvp);
 	error = null_nodeget(vp->v_mount, ldvp, dvp);
 	if (error == 0) {
 #ifdef DIAGNOSTIC