From owner-freebsd-fs@FreeBSD.ORG Fri Jan 23 14:05:56 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB5491065672 for ; Fri, 23 Jan 2009 14:05:56 +0000 (UTC) (envelope-from brampton@gmail.com) Received: from mail-ew0-f20.google.com (mail-ew0-f20.google.com [209.85.219.20]) by mx1.freebsd.org (Postfix) with ESMTP id 16C8F8FC16 for ; Fri, 23 Jan 2009 14:05:55 +0000 (UTC) (envelope-from brampton@gmail.com) Received: by ewy13 with SMTP id 13so4276573ewy.19 for ; Fri, 23 Jan 2009 06:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type; bh=aJfhWeTbo6c+s5WNRM/OagDyQ0oiwKPjXrbkpRptDIo=; b=i5GGAXkR5zLbAJvXtO4YMvuFBBBz5Bk6YnhKMbX6fYo2VMpaqGnDcipuqPBK75INfI 1daLS/x8ebtndwg7S0JNXoUswUmZ+xLMvmZJGA7G0DK3QgrloYKJLw9B5fgXNY5zTXe9 vLcPD8iaIirckPuAXgTWFmBvkx2xxCD8LFwyM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=Cx49MNHoI1W+KPDYHGHGPlf83dTx2Dj3oUP3nSgsaAbuYoYC3Xexx08ckpHKro2TeL VoWfmx2Vc5iS9U3a4K/BWyzbrGBlnxjpBHpyRl76lG02zfD89VDFXh04fhehqMlR7iMD 23KRtXbErGxlO73t0S4N8M/cYQM8EKMOOSYh0= MIME-Version: 1.0 Sender: brampton@gmail.com Received: by 10.210.19.16 with SMTP id 16mr168262ebs.92.1232719555115; Fri, 23 Jan 2009 06:05:55 -0800 (PST) In-Reply-To: <86iqo74ba1.fsf@ds4.des.no> References: <868wp4pqwm.fsf@ds4.des.no> <86iqo74ba1.fsf@ds4.des.no> Date: Fri, 23 Jan 2009 14:05:55 +0000 X-Google-Sender-Auth: f4e8734a27393c14 Message-ID: From: Andrew Brampton To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , freebsd-fs Content-Type: multipart/mixed; boundary=000e0cd1e02830babb046126e3cb Cc: Subject: Re: Pseudofs and pfs_attr_t for non-process based files X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2009 14:05:57 -0000 --000e0cd1e02830babb046126e3cb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2009/1/22 Dag-Erling Sm=C3=B8rgrav : > In procfs_attr(), the vap->va_[ug]id assignments are redundant, since at > this point pfs_getattr() has already done the exact same thing. The > rest of the patch is fine, modulo style issues which already existed in > my code. Here are both patches again, but only the procfs patch has changed. I have now removed the redundant code. thanks Andrew --000e0cd1e02830babb046126e3cb Content-Type: text/x-patch; charset=US-ASCII; name="pseudofs_vnops.patch" Content-Disposition: attachment; filename="pseudofs_vnops.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fqaxdwxo0 SW5kZXg6IHN5cy9mcy9wc2V1ZG9mcy9wc2V1ZG9mc192bm9wcy5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5 cy9mcy9wc2V1ZG9mcy9wc2V1ZG9mc192bm9wcy5jCShyZXZpc2lvbiAxODc0MTUpCisrKyBzeXMv ZnMvcHNldWRvZnMvcHNldWRvZnNfdm5vcHMuYwkod29ya2luZyBjb3B5KQpAQCAtMjI2LDE0ICsy MjYsMTcgQEAgcGZzX2dldGF0dHIoc3RydWN0IHZvcF9nZXRhdHRyX2FyZ3MgKnZhKQogCWlmIChw cm9jICE9IE5VTEwpIHsKIAkJdmFwLT52YV91aWQgPSBwcm9jLT5wX3VjcmVkLT5jcl9ydWlkOwog CQl2YXAtPnZhX2dpZCA9IHByb2MtPnBfdWNyZWQtPmNyX3JnaWQ7Ci0JCWlmIChwbi0+cG5fYXR0 ciAhPSBOVUxMKQotCQkJZXJyb3IgPSBwbl9hdHRyKGN1cnRocmVhZCwgcHJvYywgcG4sIHZhcCk7 Ci0JCVBST0NfVU5MT0NLKHByb2MpOwogCX0gZWxzZSB7CiAJCXZhcC0+dmFfdWlkID0gMDsKIAkJ dmFwLT52YV9naWQgPSAwOwogCX0KIAorCWlmIChwbi0+cG5fYXR0ciAhPSBOVUxMKQorCQllcnJv ciA9IHBuX2F0dHIoY3VydGhyZWFkLCBwcm9jLCBwbiwgdmFwKTsKKworCWlmKHByb2MgIT0gTlVM TCkKKwkJUFJPQ19VTkxPQ0socHJvYyk7CisKIAlQRlNfUkVUVVJOIChlcnJvcik7CiB9CiAK --000e0cd1e02830babb046126e3cb Content-Type: text/x-patch; charset=US-ASCII; name="procfs.patch" Content-Disposition: attachment; filename="procfs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fqaxe4gq1 SW5kZXg6IHN5cy9mcy9wcm9jZnMvcHJvY2ZzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2ZzL3Byb2Nm cy9wcm9jZnMuYwkocmV2aXNpb24gMTg3NDE1KQorKysgc3lzL2ZzL3Byb2Nmcy9wcm9jZnMuYwko d29ya2luZyBjb3B5KQpAQCAtOTksNyArOTksNiBAQCBwcm9jZnNfZG9jdXJwcm9jKFBGU19GSUxM X0FSR1MpCiBpbnQKIHByb2Nmc19hdHRyKFBGU19BVFRSX0FSR1MpCiB7Ci0JUFJPQ19MT0NLX0FT U0VSVChwLCBNQV9PV05FRCk7CiAKIAkvKiBYWFggaW5lZmZpY2llbnQsIHNwbGl0IGludG8gc2Vw YXJhdGUgZnVuY3Rpb25zICovCiAJaWYgKHN0cmNtcChwbi0+cG5fbmFtZSwgImN0bCIpID09IDAg fHwKQEAgLTExMiwxMSArMTExLDEyIEBAIHByb2Nmc19hdHRyKFBGU19BVFRSX0FSR1MpCiAJICAg IHN0cmNtcChwbi0+cG5fbmFtZSwgImZwcmVncyIpID09IDApCiAJCXZhcC0+dmFfbW9kZSA9IDA2 MDA7CiAKLQlpZiAoKHAtPnBfZmxhZyAmIFBfU1VHSUQpICYmIHBuLT5wbl90eXBlICE9IHBmc3R5 cGVfcHJvY2RpcikKLQkJdmFwLT52YV9tb2RlID0gMDsKKwlpZiAocCAhPSBOVUxMKSB7CisJCVBS T0NfTE9DS19BU1NFUlQocCwgTUFfT1dORUQpOwogCi0JdmFwLT52YV91aWQgPSBwLT5wX3VjcmVk LT5jcl91aWQ7Ci0JdmFwLT52YV9naWQgPSBwLT5wX3VjcmVkLT5jcl9naWQ7CisJCWlmICgocC0+ cF9mbGFnICYgUF9TVUdJRCkgJiYgcG4tPnBuX3R5cGUgIT0gcGZzdHlwZV9wcm9jZGlyKQorCQkJ dmFwLT52YV9tb2RlID0gMDsKKwl9CiAKIAlyZXR1cm4gKDApOwogfQo= --000e0cd1e02830babb046126e3cb--