Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Nov 2009 18:42:26 +0000 (GMT)
From:      Gavin Atkinson <gavin@FreeBSD.org>
To:        Andriy Gapon <avg@icyb.net.ua>
Cc:        freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org
Subject:   Re: heci: a new driver for review and testing
Message-ID:  <20091110184016.S61601@ury.york.ac.uk>
In-Reply-To: <4AF99F10.8020703@icyb.net.ua>
References:  <4AD6067E.2010503@icyb.net.ua> <20091109195045.Q13027@ury.york.ac.uk> <4AF95461.2030700@icyb.net.ua> <4AF99F10.8020703@icyb.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 10 Nov 2009, Andriy Gapon wrote:
> on 10/11/2009 13:54 Andriy Gapon said the following:
>> on 09/11/2009 22:34 Gavin Atkinson said the following:
>>> Secondly, I get a panic on module unlaod.  I haven't spent any time
>>> looking at this, if you haven't fixed it yet let me know and I'll look
>>> into it further.
>>
>> To my shame I still haven't got around to testing the driver with head tree and
>> diagnostics enabled.  I do not see any problems on stable/7 without diagnostics.
>> Robert Noland has reported that he had a lockup on module unload with head
>> sources.  I will investigate this.
>> BTW, 0xdeadc0dedeadc0de as arg to device_detach() looks really strange (if
>> debugger reports it correctly).  This looks like the memory was already freed.
>
> I think I've found one bug in the heci code that could cause this - SLIST element
> was first freed and then removed from the list.
> I've uploaded updated sources (that should include your PCI ID too), could you
> please re-test?

That seems to have fixed it, thanks!  It also fixes the malloc() calls 
with locks held.

> Could you please send me verbose version of driver attachment messages
> (debug.bootverbose=1)?
> Thank you!

Sure!

http://people.freebsd.org/~gavin/heci-verbose.txt

Gavin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091110184016.S61601>