From owner-freebsd-scsi@FreeBSD.ORG Mon Aug 26 15:48:31 2013 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 25E73F1F for ; Mon, 26 Aug 2013 15:48:31 +0000 (UTC) (envelope-from will@firepipe.net) Received: from mail-vb0-f51.google.com (mail-vb0-f51.google.com [209.85.212.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DA0712C8E for ; Mon, 26 Aug 2013 15:48:30 +0000 (UTC) Received: by mail-vb0-f51.google.com with SMTP id x16so2216659vbf.10 for ; Mon, 26 Aug 2013 08:48:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sLhFzsmR7oKGkaNxTl+Kn+n31feuAz3Q6N19j8geUsI=; b=L+MSVbQW9qzsA9ZK8RTf8Z3eI43OiSP2+gHlnVOe+WmOPNI8tTCyChgPpdi5Yv7xVK qpsRQQdbja/zdQyq0dkVPPcyDM4aSQA538OfjMEwQROGRkqtAb0uDBMgFJWeLt5FPmfd k4QsYSe1VyARZS6jLQ5aept7PrZhYiuYEKjdAsXm9mvcNVGcyIfU7N/GgkKpxKFtHjm3 PktXbLpXYfC+9HVsphu0wHfmq1JwxmXnsBP4Cav2DsZcUfWjgZhYR573XENHWQedtYjE dbG9+RJRlHrCM3ffLaLvsBcOVLPfehOvgBDieSPub8jmlHwrC+QvGXm956zzhhqzCVOn pUPw== X-Gm-Message-State: ALoCoQmA5FdFye1bkJn9ZcV7KrsSNxyBzrN8OJ9EZ6tSlRn8PB/nVg1Zi9c1ojIeQSCHYW8aiXeA MIME-Version: 1.0 X-Received: by 10.58.165.70 with SMTP id yw6mr6524745veb.19.1377531624960; Mon, 26 Aug 2013 08:40:24 -0700 (PDT) Received: by 10.58.226.66 with HTTP; Mon, 26 Aug 2013 08:40:24 -0700 (PDT) In-Reply-To: References: Date: Mon, 26 Aug 2013 09:40:24 -0600 Message-ID: Subject: Re: 8K quirks & making quirk table more structured From: Will Andrews To: Steven Hartland Content-Type: text/plain; charset=UTF-8 Cc: scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2013 15:48:31 -0000 On Sat, Aug 24, 2013 at 4:24 PM, Steven Hartland wrote: > That currently breaks the main reason for the output of > quirks in xpt_announce_quirks The main reason for the output of quirks is for those that you can't find any other way. Blocksize is something you can obtain from diskinfo, so what is the point of putting it in quirks? Just to spam dmesg? > Also it appears that the new method of setting lbppbe > in scsi would make the result dependent on block_len > which makes it potentially hard to predict the value > needed to set a drive to 4 etc. A fair point. I would prefer to address this issue in a followup commit, perhaps as part of harmonizing the quirk tables. See below. > In ata you use a different method entirely which its > not good for consistency as ideally we should have just > one set of quirks which work for scsi and ata. Yes, but this problem already exists and is not made worse by this change. We can debate this issue, but I consider it a separate one from converting the quirk entry type. > Also in ata you appear to have lost the output of quirks. In ata, there aren't any quirks aside from 4K. --Will.