From owner-svn-src-all@FreeBSD.ORG  Sun Jun 14 04:38:18 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 79C0D2C4;
 Sun, 14 Jun 2015 04:38:18 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DF6C5CA2;
 Sun, 14 Jun 2015 04:38:17 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t5E4c8VS090740
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sun, 14 Jun 2015 07:38:08 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t5E4c8VS090740
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t5E4c82x090739;
 Sun, 14 Jun 2015 07:38:08 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 14 Jun 2015 07:38:08 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Garrett Cooper <yaneurabeya@gmail.com>
Cc: araujo@FreeBSD.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Allan Jude <allanjude@freebsd.org>
Subject: Re: svn commit: r284336 - head/sys/dev/acpi_support
Message-ID: <20150614043808.GL2080@kib.kiev.ua>
References: <201506130555.t5D5tQij003839@svn.freebsd.org>
 <20150613073746.GJ2080@kib.kiev.ua>
 <CAGHfRMBuRA2w6y8rG+OBEK8qW1e8BSbXyrULvBpgMc=_1fnXKg@mail.gmail.com>
 <CAOfEmZhjMhje7CwjAKDLgD-QUV5ksV17RNaKpW24uHcsDa3Hdg@mail.gmail.com>
 <17D20218-2A87-4F1E-BF8C-563C38305C51@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17D20218-2A87-4F1E-BF8C-563C38305C51@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jun 2015 04:38:18 -0000

On Sat, Jun 13, 2015 at 03:31:16PM -0700, Garrett Cooper wrote:
> On Jun 13, 2015, at 4:30, Marcelo Araujo <araujobsdport@gmail.com> wrote:
> 
> > +1.
> 
> Fixed (r284357/r284358). Thanks!

I doubt that anything is fixed.

>From a little information I can gather from the r284336 commit message,
there was some NULL pointer dereference (may be not, FWIW). The r284336
papered over it, just ignoring the chunk of code when bith env variables
are _not_ NULL. Now, the condition is reversed, and since r284336
hide the bug, it is arguable that both env vars were not NULL on the
problematic machines.

The consequence is that the check is a nop now, since machines do have
valid SMBIOS info, and a bug, whatever it is, is not fixed, and probably
not even diagnosed.