From owner-svn-src-all@freebsd.org Wed Apr 13 03:02:35 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70EADB0E9DA; Wed, 13 Apr 2016 03:02:35 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 599F71596; Wed, 13 Apr 2016 03:02:35 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 509AB17D9; Wed, 13 Apr 2016 03:02:35 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 014371E45E; Wed, 13 Apr 2016 03:02:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id j5MUL4hn4JHC; Wed, 13 Apr 2016 03:02:32 +0000 (UTC) Subject: Re: svn commit: r297902 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 225881E457 To: Steve Wills , Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <570DB6C7.6050201@FreeBSD.org> Date: Tue, 12 Apr 2016 20:02:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <570DB63F.9060907@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gchJOQe7LfteundcXeAGjJB9uEWMr31v7" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 03:02:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gchJOQe7LfteundcXeAGjJB9uEWMr31v7 Content-Type: multipart/mixed; boundary="XUfm6KkT5nkCjhN4biLmobjIqORG1itBd" From: Bryan Drewery To: Steve Wills , Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <570DB6C7.6050201@FreeBSD.org> Subject: Re: svn commit: r297902 - head References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org> In-Reply-To: <570DB63F.9060907@FreeBSD.org> --XUfm6KkT5nkCjhN4biLmobjIqORG1itBd Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/12/2016 8:00 PM, Steve Wills wrote: > On 04/12/16 09:59 PM, Ian Lepore wrote: >> >> More succinctly: >> >> .if empty(SVN) >> SVN!=3D which svn || which svnlite >> .endif >> >=20 > Fair enough, that's basically the intent. I think we like to avoid !=3D= , > at least in ports, and I wanted the logic between src and ports to matc= h > in this case. >=20 Yeah, please avoid !=3D where possible. If you switch to this then also add .export SVN after the SVN!=3D line. I somewhat like this version more though since /usr/local/bin may not be in the PATH. --=20 Regards, Bryan Drewery --XUfm6KkT5nkCjhN4biLmobjIqORG1itBd-- --gchJOQe7LfteundcXeAGjJB9uEWMr31v7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXDbbHAAoJEDXXcbtuRpfPRzEIALvR5Las93BHTcguLNM50phD HA5QR4hoy51YK/ciljFs+1ZCzpynH/Zjx+OLIi8V5dU9ZW8LL3xmGo+/UOVG1ilr G7DMhJoAJ4/GI8nIdUTCeE6vrmbJU+CHu7erBqBUbz+FFm1yIAHVOpppoJmagG+Y YMxrr7BdsJ5GE7SqChBxlU4qGAhfdaCdJCopU2rbtTW7/K1I1G8lc+iWX0lP7+qw cXmsEA/0tHUecVZDKwBf74qhtuCfp5J3rZpgH/CmlWpAoCHk5Pvd538TQLiHovey 4RTMYc9Wt9q8D2gB9okAxjFtqhXx6f8lEmPJPeRT9ISC5d38kkg+4YAdaXSVmp0= =H/fW -----END PGP SIGNATURE----- --gchJOQe7LfteundcXeAGjJB9uEWMr31v7--