Date: Sat, 8 Jan 2000 14:38:23 +0100 (CET) From: Luigi Rizzo <luigi@info.iet.unipi.it> To: Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp> Cc: luigi@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c ip_dummynet.h Message-ID: <200001081338.OAA10400@info.iet.unipi.it> In-Reply-To: <20000108214808C.shin@nd.net.fujitsu.co.jp> from Yoshinobu Inoue at "Jan 8, 2000 09:48:08 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> Please pass pkt->flags value as ip_output() flags argument, > if it is not problem. it _is_ passed, just not in the ip_output() argument but through the pkt structure --look at the changes in ip_output.c > By the way, > > > as well. Also (probably) fix a bug introduced during the IPv6 import. > > did I break anything related to dummynet? > I thought I only changed ip_output() arguments related part, > and also confirmed it to work, but if there was any problem, > I'm much sorry for it. no reason to apologise :) Thanks for your work, indeed! I am not 100% sure but I think the flag argument was already used for some other purpose to pass parameters to ip_output() (probably the destination interface or something like that). So your change might have rendered that parameter invalid, but if memory serves, the bug would be only evidenced with multihomed systems and/or acting as gateways. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) Mobile +39-347-0373137 -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001081338.OAA10400>