Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jan 2001 07:52:48 +0300
From:      "Valeriy E. Ushakov" <uwe@ptc.spbu.ru>
To:        Soren Schmidt <sos@freebsd.dk>
Cc:        Josef Karthauser <joe@tao.org.uk>, Soren Schmidt <sos@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, freebsd-multimedia@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/dev/ata atapi-cd.c
Message-ID:  <20010119075248.A27136@snark.ptc.spbu.ru>
In-Reply-To: <200101181542.QAA25804@freebsd.dk>; from "Soren Schmidt" on Thu, Jan 18, 2001 at 16:42:21
References:  <20010118153731.B89385@tao.org.uk> <200101181542.QAA25804@freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
Hey.  Thanks, Soren!

On Thu, Jan 18, 2001 at 16:42:21 +0100, Soren Schmidt wrote:

> > On Thu, Jan 18, 2001 at 07:20:19AM -0800, Soren Schmidt wrote:
> > > sos         2001/01/18 07:20:19 PST
> > > 
> > >   Modified files:
> > >     sys/dev/ata          atapi-cd.c 
> > >   Log:
> > >   When blocksize is set to 2352, alwas read 2352 bytes.
> > >   This means it might read more than just data, but that is exactly
> > >   what we want here (for reading VCD's fx)
> > 
> > Does this fix the reading of video cds or is the more to come?
> 
> Yes, no.
> 
> I have a patched input_vcd.c for xine and that works dandy, except
> for the sound which xine thinks should be ac3 :)

I have wrote a patch for smpeg the other night, that teaches it to
read VCD tracks as files, not as streams (basicly, it implements a
read and lseek and smpeg is tweaked to use "virtual" files, i.e. a
handle + access functions).  The benefit of this approach is that it
eliminates problems with seeking.

Since at my job I have a beta code freeze approaching, I don't have
any time to work on this patch further.  Anyone interested in taking
it and adding buffering support (I was thinking about a circular
buffer and a separate thread to read data from the device)?  Currently
the patched smpeg works just fine, but a little bit jerky for VCDs
when data are read from device.

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010119075248.A27136>