Date: Fri, 25 Mar 2011 16:10:15 GMT From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: freebsd-fs@FreeBSD.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD Message-ID: <201103251610.p2PGAFOb063448@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/152079; it has been noted by GNATS.
From: "Pedro F. Giffuni" <giffunip@tutopia.com>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD
Date: Fri, 25 Mar 2011 09:09:04 -0700 (PDT)
--0-691748129-1301069344=:71034
Content-Type: text/plain; charset=us-ascii
Include a small fix from NetBSD:
msdosfs_vnops.c Revision 1.73:
Remove a vnode reference leak from msdosfs_rename. Release tdvp if either
doscheckpath() or relookup() fails.
Adjust test fs/vfs/t_vnops.c and remove the link count test for msdos.
Fixes NetBSD PR #44661
--0-691748129-1301069344=:71034
Content-Type: text/plain; name="patch-msdosfs.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="patch-msdosfs.txt"
ZGlmZiAtcnUgbXNkb3Nmcy5vcmlnL2Rlbm9kZS5oIG1zZG9zZnMvZGVub2Rl
LmgKLS0tIG1zZG9zZnMub3JpZy9kZW5vZGUuaAkyMDExLTAzLTI1IDEwOjM0
OjQxLjAwMDAwMDAwMCArMDAwMAorKysgbXNkb3Nmcy9kZW5vZGUuaAkyMDEx
LTAzLTI1IDEwOjM3OjA3LjAwMDAwMDAwMCArMDAwMApAQCAtNDcsNiArNDcs
OCBAQAogICoKICAqIE9jdG9iZXIgMTk5MgogICovCisjaWZuZGVmIF9GU19N
U0RPU0ZTX0RFTk9ERV9IXworI2RlZmluZSBfRlNfTVNET1NGU19ERU5PREVf
SF8KIAogLyoKICAqIFRoaXMgaXMgdGhlIHBjIGZpbGVzeXN0ZW0gc3BlY2lm
aWMgcG9ydGlvbiBvZiB0aGUgdm5vZGUgc3RydWN0dXJlLgpAQCAtMjA3LDgg
KzIwOSw2IEBACiAJICAgICAoKGRlcCktPmRlX0F0dHJpYnV0ZXMgJiBBVFRS
X0RJUkVDVE9SWSkgPyAwIDogKGRlcCktPmRlX0ZpbGVTaXplKSwgXAogCSBw
dXR1c2hvcnQoKGRwKS0+ZGVIaWdoQ2x1c3QsIChkZXApLT5kZV9TdGFydENs
dXN0ZXIgPj4gMTYpKQogCi0jaWZkZWYgX0tFUk5FTAotCiAjZGVmaW5lCVZU
T0RFKHZwKQkoKHN0cnVjdCBkZW5vZGUgKikodnApLT52X2RhdGEpCiAjZGVm
aW5lCURFVE9WKGRlKQkoKGRlKS0+ZGVfdm5vZGUpCiAKQEAgLTI1NCw2ICsy
NTQsOCBAQAogI2VuZGlmCiB9OwogCisjaWZkZWYgX0tFUk5FTAorCiBleHRl
cm4gc3RydWN0IHZvcF92ZWN0b3IgbXNkb3Nmc192bm9kZW9wczsKIAogaW50
IG1zZG9zZnNfbG9va3VwKHN0cnVjdCB2b3BfY2FjaGVkbG9va3VwX2FyZ3Mg
Kik7CkBAIC0yNzksMyArMjgxLDQgQEAKIGludCBkZXRydW5jKHN0cnVjdCBk
ZW5vZGUgKmRlcCwgdV9sb25nIGxlbmd0aCwgaW50IGZsYWdzLCBzdHJ1Y3Qg
dWNyZWQgKmNyZWQsIHN0cnVjdCB0aHJlYWQgKnRkKTsKIGludCBkb3NjaGVj
a3BhdGgoIHN0cnVjdCBkZW5vZGUgKnNvdXJjZSwgc3RydWN0IGRlbm9kZSAq
dGFyZ2V0KTsKICNlbmRpZgkvKiBfS0VSTkVMICovCisjZW5kaWYgLyogIV9G
U19NU0RPU0ZTX0RFTk9ERV9IXyAqLwpkaWZmIC1ydSBtc2Rvc2ZzLm9yaWcv
bXNkb3Nmc19sb29rdXAuYyBtc2Rvc2ZzL21zZG9zZnNfbG9va3VwLmMKLS0t
IG1zZG9zZnMub3JpZy9tc2Rvc2ZzX2xvb2t1cC5jCTIwMTEtMDMtMjUgMTA6
MzQ6NDEuMDAwMDAwMDAwICswMDAwCisrKyBtc2Rvc2ZzL21zZG9zZnNfbG9v
a3VwLmMJMjAxMS0wMy0yNSAxMDozNzowNy4wMDAwMDAwMDAgKzAwMDAKQEAg
LTQ1OCw3ICs0NTgsNyBAQAogCQkgKiBEb24ndCBhbGxvdyBkZWxldGluZyB0
aGUgcm9vdC4KIAkJICovCiAJCWlmIChibGtvZmYgPT0gTVNET1NGU1JPT1Rf
T0ZTKQotCQkJcmV0dXJuIEVST0ZTOwkJCQkvKiByZWFsbHk/IFhYWCAqLwor
CQkJcmV0dXJuIEVJTlZBTDsKIAogCQkvKgogCQkgKiBXcml0ZSBhY2Nlc3Mg
dG8gZGlyZWN0b3J5IHJlcXVpcmVkIHRvIGRlbGV0ZSBmaWxlcy4KQEAgLTQ5
MSw3ICs0OTEsNyBAQAogCSAqLwogCWlmIChuYW1laW9wID09IFJFTkFNRSAm
JiAoZmxhZ3MgJiBJU0xBU1RDTikpIHsKIAkJaWYgKGJsa29mZiA9PSBNU0RP
U0ZTUk9PVF9PRlMpCi0JCQlyZXR1cm4gRVJPRlM7CQkJCS8qIHJlYWxseT8g
WFhYICovCisJCQlyZXR1cm4gRUlOVkFMOwogCiAJCWVycm9yID0gVk9QX0FD
Q0VTUyh2ZHAsIFZXUklURSwgY25wLT5jbl9jcmVkLCBjbnAtPmNuX3RocmVh
ZCk7CiAJCWlmIChlcnJvcikKZGlmZiAtcnUgbXNkb3Nmcy5vcmlnL21zZG9z
ZnNfdm5vcHMuYyBtc2Rvc2ZzL21zZG9zZnNfdm5vcHMuYwotLS0gbXNkb3Nm
cy5vcmlnL21zZG9zZnNfdm5vcHMuYwkyMDExLTAzLTI1IDEwOjM0OjQxLjAw
MDAwMDAwMCArMDAwMAorKysgbXNkb3Nmcy9tc2Rvc2ZzX3Zub3BzLmMJMjAx
MS0wMy0yNSAxMTowMDo1NS4wMDAwMDAwMDAgKzAwMDAKQEAgLTEwOTQsMTIg
KzEwOTQsMTIgQEAKIAkJICovCiAJCWVycm9yID0gZG9zY2hlY2twYXRoKGlw
LCBkcCk7CiAJCWlmIChlcnJvcikKLQkJCWdvdG8gb3V0OworCQkJZ290byBi
YWQ7CiAJCWlmICgodGNucC0+Y25fZmxhZ3MgJiBTQVZFU1RBUlQpID09IDAp
CiAJCQlwYW5pYygibXNkb3Nmc19yZW5hbWU6IGxvc3QgdG8gc3RhcnRkaXIi
KTsKIAkJZXJyb3IgPSByZWxvb2t1cCh0ZHZwLCAmdHZwLCB0Y25wKTsKIAkJ
aWYgKGVycm9yKQotCQkJZ290byBvdXQ7CisJCQlnb3RvIGJhZDsKIAkJZHAg
PSBWVE9ERSh0ZHZwKTsKIAkJeHAgPSB0dnAgPyBWVE9ERSh0dnApIDogTlVM
TDsKIAl9CkBAIC0xMjgzLDcgKzEyODMsNiBAQAogCWlmICh4cCkKIAkJdnB1
dCh0dnApOwogCXZwdXQodGR2cCk7Ci1vdXQ6CiAJaXAtPmRlX2ZsYWcgJj0g
fkRFX1JFTkFNRTsKIAl2cmVsZShmZHZwKTsKIAl2cmVsZShmdnApOwo=
--0-691748129-1301069344=:71034--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103251610.p2PGAFOb063448>