Date: Thu, 22 Sep 2011 08:53:16 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-bugs@freebsd.org, Warner Losh <imp@freebsd.org>, linimon@freebsd.org Subject: Re: conf/160896: [nanobsd] [patch] use getopts, jobs option, delay -c usage improvements to nanobsd.sh Message-ID: <CAGH67wQzr782P1k449kNNz3u0Gpse6pz8N6ix9t3zmMO1xQLzg@mail.gmail.com> In-Reply-To: <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com> References: <201109220755.p8M7t0Vx081424@freefall.freebsd.org> <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 22, 2011 at 1:57 AM, Warner Losh <imp@bsdimp.com> wrote:
> Rejecting parts of this patch. =A0Specifically, the delated -c stuff is b=
ogusly implemented. =A0Before the change, you could have multiple -c option=
s on the command line. =A0after this you can't.
I'm wouldn't mind doing something like this:
nano_confs
while getopts '...' optch
do
case "$optch" in
...
c)
nano_confs=3D"$nano_confs $OPTARG"
;;
...
for nano_conf in $nano_confs; do
. $nano_confs
done
The problem I was trying to work around is that (unfortunately) some
packages code features (ipv6) into the names (take apr for instance),
which means that the logic in FreeNAS currently always says "build a
fat image" when $DEBUG =3D=3D 1.
> Don't like how -j is implemented in this patch. =A0Need to think about th=
is because it breaks some nanobsd config files that specify NANO_PMAKE comm=
and.
My concern was that not all of my build machines are homogeneous. I
have access to some "powerhouse" server machines and some low power
desktops. FreeNAS had -j8 coded into NANO_PMAKE, but I made it
variable ($CPUS), but I thought that was a bad idea for what should go
back into nanobsd (it didn't match the defaults and could cause other
issues) -- if the default (1) is incorrect, I'm all for bumping it up
to 3 again. I just wasn't sure why 3 was the chosen default.
> Other stuff looks good and it, or variations of it, will go in when we're=
out of the freeze.
Thanks for the feedback!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQzr782P1k449kNNz3u0Gpse6pz8N6ix9t3zmMO1xQLzg>