From owner-svn-src-head@FreeBSD.ORG Sat Dec 15 22:54:42 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D640EEC8; Sat, 15 Dec 2012 22:54:42 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp4.clear.net.nz (smtp4.clear.net.nz [203.97.37.64]) by mx1.freebsd.org (Postfix) with ESMTP id 915B48FC0A; Sat, 15 Dec 2012 22:54:42 +0000 (UTC) Received: from mxin1-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp4.clear.net.nz (CLEAR Net Mail) with ESMTP id <0MF300HJJG9O5950@smtp4.clear.net.nz>; Sun, 16 Dec 2012 11:39:35 +1300 (NZDT) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin1.paradise.net.nz with ESMTP; Sun, 16 Dec 2012 11:39:34 +1300 Date: Sun, 16 Dec 2012 11:39:21 +1300 From: Andrew Turner Subject: Re: svn commit: r244278 - head/sys/boot/arm/uboot In-reply-to: To: Garrett Cooper Message-id: <20121216113921.0c9e2c9b@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.1) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr References: <201212152147.qBFLl6f1043013@svn.freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 22:54:42 -0000 On Sat, 15 Dec 2012 13:57:02 -0800 Garrett Cooper wrote: > On Dec 15, 2012, at 1:47 PM, Andrew Turner wrote: > > > Author: andrew > > Date: Sat Dec 15 21:47:05 2012 > > New Revision: 244278 > > URL: http://svnweb.freebsd.org/changeset/base/244278 > > > > Log: > > Ignore a warning in ubldr where clang doesn't understand the %D > > printf specifier from libstand. > > > > Modified: > > head/sys/boot/arm/uboot/Makefile > > > > Modified: head/sys/boot/arm/uboot/Makefile > > ============================================================================== > > --- head/sys/boot/arm/uboot/Makefile Sat Dec 15 21:33:12 > > 2012 (r244277) +++ head/sys/boot/arm/uboot/Makefile > > Sat Dec 15 21:47:05 2012 (r244278) @@ -109,6 +109,9 @@ > > CFLAGS+= -I${.OBJDIR}/../../uboot/lib # where to get > > libstand from CFLAGS+= -I${.CURDIR}/../../../../lib/libstand/ > > > > +# clang doesn't understand %D as a specifier to printf > > +NO_WERROR.clang= > > + > > DPADD= ${LIBFICL} ${LIBUBOOT} ${LIBFDT} ${LIBSTAND} > > LDADD= ${LIBFICL} ${LIBUBOOT} ${LIBFDT} -lstand > > Why not fix it similar to how I fixed libi386/pxe.c on my git > branch > ( https://github.com/yaneurabeya/freebsd/commit/709c2b0a47ec887f8df3a886d318c309a0659bf6 > )? Thanks, -Garrett > When you commit the sys/boot/common/dev_net.c change from that patch we should be able to revert this commit. Andrew