From owner-svn-src-head@freebsd.org Sat Apr 21 17:59:06 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDB86FB6C1D; Sat, 21 Apr 2018 17:59:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57BEC6A576; Sat, 21 Apr 2018 17:59:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id v13-v6so13959294iob.6; Sat, 21 Apr 2018 10:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=ulRyKD0u8kkCGd7g+chbmF/j4icsVSqoiChkW9Td2Wc=; b=NmsS6lFjo3gOhL3PRVLYvzRnLfcroXQD5j15rID0KUcP6Ue68TAxfjsNIsrrvKR5PD xCVECHjuJsbFZxplEm7a83AzlAlur7BqLnuVVZwEAQ7IKPn65qi8C4tXrEBQe5JPrEQK +qT/tx4ECCq95IeM4uGj2bLYaOY2JPMWcSPqpnXiQ3qLjdmll7xzI2NV2FGDf+9z+RAD h3NAvlh8B17UmxzHSgOlPYgsutuu+94DGObzdMfwDvuNyQbA944l+g72DyRcVFajapUC MAys3Nqub8GUj2ueod5xun99FE9VQd2OIqBWLtHBYJX8y05PYIn1Vz8lFkudXdEH0sWq +eXw== X-Gm-Message-State: ALQs6tD0JJPfjlgwcbKKqSIf05RCtqkUxZbsISCZtCAGukszt9fxvpJr EZT6kyskR6/BEHTl787xkM08yF9c X-Google-Smtp-Source: AIpwx49bvg8k0NL4q+VT4XLtnjoRe995sAxlR/cqx8nK216CH01Fj9KdbjSQmE1G/FxyuS/NfdXViQ== X-Received: by 2002:a6b:e815:: with SMTP id f21-v6mr8976736ioh.244.1524333540325; Sat, 21 Apr 2018 10:59:00 -0700 (PDT) Received: from mail-io0-f170.google.com (mail-io0-f170.google.com. [209.85.223.170]) by smtp.gmail.com with ESMTPSA id o187-v6sm1434866ioo.65.2018.04.21.10.58.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Apr 2018 10:59:00 -0700 (PDT) Received: by mail-io0-f170.google.com with SMTP id r22-v6so4892052ioc.12; Sat, 21 Apr 2018 10:58:59 -0700 (PDT) X-Received: by 2002:a6b:545:: with SMTP id 66-v6mr15145876iof.173.1524333539841; Sat, 21 Apr 2018 10:58:59 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:224d:0:0:0:0:0 with HTTP; Sat, 21 Apr 2018 10:58:59 -0700 (PDT) In-Reply-To: <20180422032027.D1653@besplex.bde.org> References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <20180422032027.D1653@besplex.bde.org> From: Conrad Meyer Date: Sat, 21 Apr 2018 10:58:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332860 - head/sys/kern To: Bruce Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Apr 2018 17:59:07 -0000 On Sat, Apr 21, 2018 at 10:41 AM, Bruce Evans wrote: > panic() can't return, but I see that KASSERT() has already been broken > to use kassert_panic() which does return in some cases including this > new one. Oddly enough, I find myself agreeing with Bruce on this. That kassert_panic does not always assert, during ordinary (non-panic) runtime, based on a runtime configurable toggle breaks the concept of invariants and confuses the heck out of static analyzers like Coverity. Ideally, we just remove it. IMO it is a crappy hack that should have remained in iX's local tree. If we want to be really generous, we can make it an off-by-default build option. Is anyone clamoring for allowing violation of multiple assertions without panic, other than Linus Torvalds? > KASSERT(9) is still documented to call panic(), and none of the options > to break it including this new one, or kassert_panic() itself are > documented in KASSERT(9) or in any other section 9 man page. Yeah. This is unfortunate :-(. Best, Conrad