From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu May  8 07:10:55 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B85711065679
	for <freebsd-ports-bugs@FreeBSD.org>;
	Thu,  8 May 2008 07:10:55 +0000 (UTC) (envelope-from js@iksz.hu)
Received: from smtp.aranyoroszlan.hu (smtp.aranyoroszlan.hu [195.56.77.57])
	by mx1.freebsd.org (Postfix) with ESMTP id AE9BA8FC1B
	for <freebsd-ports-bugs@FreeBSD.org>;
	Thu,  8 May 2008 07:10:54 +0000 (UTC) (envelope-from js@iksz.hu)
Received: (qmail 65416 invoked by uid 263); 8 May 2008 06:53:01 -0000
Received: from 213.178.104.16 (js@iksz.hu@213.178.104.16) by
	tcb.aranyoroszlan.hu (envelope-from <js@iksz.hu>,
	uid 256) with qmail-scanner-2.02st 
	(clamdscan: 0.92/5779. spamassassin: 3.2.4. perlscan: 2.02st.  
	Clear:RC:0(213.178.104.16):SA:0(1.5/5.0):. 
	Processed in 2.28001 secs); 08 May 2008 06:53:01 -0000
X-Spam-Status: No, hits=1.5 required=5.0
X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on tcb.aranyoroszlan.hu
X-Spam-Level: *
X-Spam-Status: No, score=1.5 required=5.0 tests=AWL,RCVD_IN_PBL,RDNS_NONE,
	SPF_NEUTRAL autolearn=disabled version=3.2.4
X-Envelope-From: js@iksz.hu
Received: from unknown (HELO ?192.168.1.100?) (js@iksz.hu@213.178.104.16)
	by tcb.aranyoroszlan.hu with SMTP; 8 May 2008 06:52:58 -0000
Message-ID: <4822A12F.8060401@iksz.hu>
Date: Thu, 08 May 2008 08:43:59 +0200
From: =?ISO-8859-2?Q?Nagy_Bal=E1zs?= <js@iksz.hu>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: itetcu@FreeBSD.org
References: <200805070816.m478GvhE084231@freefall.freebsd.org>
In-Reply-To: <200805070816.m478GvhE084231@freefall.freebsd.org>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-ports-bugs@FreeBSD.org, sluggo@unknown.nu
Subject: Re: ports/122586: Update to sysutils/logrotate
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 May 2008 07:10:55 -0000

itetcu@FreeBSD.org wrote:
> maintainer timeout
>   

Sorry, I just *thought* I responded.  About the patch:

logrotate/files/logrotate.conf.sample: I wouldn't remove the inclusion 
of specific config files in logrotate.d directory.  It doesn't hurt if 
it's not there.

/var/log/logrotate.status -> /var/run/logrotate.status: that's great!

patch-dateext: the included logrotate-3.7.1-maxage.patch: it removes the 
manual reference of a feature implemented there.  Don't do it.  Please 
modify your patch to append your changes to the man page *after* 
patch-dateext applied, and don't remove description of active functionality.

I can't agree to this patch in this current form.

Regards,
-jul-