From owner-p4-projects Fri Mar 22 14:13:38 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 40D1D37B404; Fri, 22 Mar 2002 14:13:32 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 38DB337B41D for ; Fri, 22 Mar 2002 14:13:31 -0800 (PST) Received: (from perforce@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g2MMDVw34831 for perforce@freebsd.org; Fri, 22 Mar 2002 14:13:31 -0800 (PST) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Fri, 22 Mar 2002 14:13:31 -0800 (PST) Message-Id: <200203222213.g2MMDVw34831@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson Subject: PERFORCE change 8215 for review To: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8215 Change 8215 by rwatson@rwatson_curry on 2002/03/22 14:13:21 Move policy field offset above LIST_ENTRY() in mpc so that we don't have to explicitly initialize the list entry. In the current code, this actually generated an error because the structure was being set to NULL rather than the elements of the list. Since we don't want to see inside opaque LIST_ENTRY, leave it at the end so it's implicitly initialized to 0's. Affected files ... ... //depot/projects/trustedbsd/mac/sys/sys/mac_policy.h#51 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/sys/mac_policy.h#51 (text+ko) ==== @@ -205,8 +205,8 @@ char *mpc_name; /* policy name */ char *mpc_fullname; /* policy full name */ struct mac_policy_ops *mpc_ops; /* policy operations */ + int mpc_field_off; /* security field */ LIST_ENTRY(mac_policy_conf) mpc_list; /* global list */ - int mpc_field_off; /* security field */ }; #define MAC_POLICY_SET(mpops, mpname, mpfullname, privdata_wanted) \ @@ -214,7 +214,6 @@ #mpname, \ mpfullname, \ &mpops, \ - NULL, \ privdata_wanted \ }; \ static moduledata_t mpname ## _mod = { \ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message