From owner-freebsd-arch@FreeBSD.ORG  Fri Jan 13 17:20:56 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5590A16A41F;
	Fri, 13 Jan 2006 17:20:56 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D519443D68;
	Fri, 13 Jan 2006 17:20:51 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id k0DHKojY099779
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 13 Jan 2006 20:20:50 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id k0DHKnHd099778;
	Fri, 13 Jan 2006 20:20:49 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Fri, 13 Jan 2006 20:20:49 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Xin LI <delphij@FreeBSD.org>
Message-ID: <20060113172049.GG83922@cell.sick.ru>
References: <20060113170552.GF83922@FreeBSD.org>
	<20060113171759.GA1255@hub.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20060113171759.GA1255@hub.freebsd.org>
User-Agent: Mutt/1.5.6i
Cc: arch@FreeBSD.org, re@FreeBSD.org
Subject: Re: review: patch to restore VLAN kernel API in RELENG_6
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2006 17:20:56 -0000

On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> Hi, Gleb,
X> > ===================================================================
X> > RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
X> > retrieving revision 1.91.2.7
X> > diff -u -r1.91.2.7 if_bge.c
X> > --- sys/dev/bge/if_bge.c	13 Jan 2006 11:51:08 -0000	1.91.2.7
X> > +++ sys/dev/bge/if_bge.c	13 Jan 2006 17:04:31 -0000
X> > @@ -2862,7 +2862,7 @@
X> >  		 * attach that information to the packet.
X> >  		 */
X> >  		if (have_tag) {
X> > -			VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > +			VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X> 
X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X> 
X> Just my $0.02, though :-)

I really don't care. :)

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE