From owner-cvs-all  Fri Dec 28 12:42:22 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1E98C37B41E; Fri, 28 Dec 2001 12:42:14 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA06513;
	Sat, 29 Dec 2001 07:42:11 +1100
Date: Sat, 29 Dec 2001 07:36:12 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Josef Karthauser <joe@FreeBSD.org>
Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/bin/ls print.c
In-Reply-To: <200112281843.fBSIhW129197@freefall.freebsd.org>
Message-ID: <20011229072756.E1997-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, 28 Dec 2001, Josef Karthauser wrote:

> joe         2001/12/28 10:43:32 PST
>
>   Modified files:
>     bin/ls               print.c
>   Log:
>   Make the style more consistent throughout the file.
>
>   Revision  Changes    Path
>   1.42      +70 -57    src/bin/ls/print.c

This adds style bugs where there were none before in approximately 60%
of the changed lines (the names of local variables are not indented in
KNF).  Please back out the regressions.  Most of them are easy to fix
by restoring code from rev.1.1.

The colorizing code needs some more cleanups.  colortype() is especially
ugly.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message