From owner-svn-src-head@freebsd.org  Fri Aug 25 22:37:58 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DE93DE2D4E;
 Fri, 25 Aug 2017 22:37:58 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 31E90731C5;
 Fri, 25 Aug 2017 22:37:58 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v7PMbqiL006177
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 26 Aug 2017 01:37:52 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v7PMbqiL006177
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v7PMbqcA006176;
 Sat, 26 Aug 2017 01:37:52 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sat, 26 Aug 2017 01:37:52 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r306512 - in head/sys: kern sys
Message-ID: <20170825223752.GN1700@kib.kiev.ua>
References: <201609301727.u8UHRIgD051373@repo.freebsd.org>
 <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org>
 <20170825103534.GK1700@kib.kiev.ua>
 <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 22:37:58 -0000

On Fri, Aug 25, 2017 at 02:29:28PM -0700, Bryan Drewery wrote:
> https://people.freebsd.org/~bdrewery/patches/vdrop-global-list.diff
I do not object against his handling.

There is really very small amount of code shared between mp != NULL
and mp == NULL cases, you may consider making them use separate paths
instead of adding more than one check for mp != NULL.

VNASSERT() statement has wrong indent on the continuation line.