From owner-freebsd-net Tue Oct 2 19: 5:33 2001 Delivered-To: freebsd-net@freebsd.org Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by hub.freebsd.org (Postfix) with ESMTP id EA53937B401 for ; Tue, 2 Oct 2001 19:05:30 -0700 (PDT) Received: from wonky.feral.com (wonky.feral.com [192.67.166.7]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id f9325NH96944; Tue, 2 Oct 2001 19:05:23 -0700 (PDT) (envelope-from mjacob@feral.com) Date: Tue, 2 Oct 2001 19:04:40 -0700 (PDT) From: Matthew Jacob Reply-To: To: "Matthew N. Dodd" Cc: Julian Elischer , Garrett Wollman , Subject: Re: review of minor clarifying comments In-Reply-To: Message-ID: <20011002190406.W4030-100000@wonky.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, 2 Oct 2001, Matthew N. Dodd wrote: > On Mon, 1 Oct 2001, Matthew Jacob wrote: > > Yes- this may have been true for a long time - but quite a number of > > Unix variants don't require it, so I forgot :-).. For example, neither > > OpenBSD nor NetBSD seem to require it. > > > > It turns out that this is only stumbled on rarely- but if it's all the same to > > you, a comment would help a lot. > > It looks like storing a pointer to struct arpcom in struct ifnet might > solve most of the cases where ifp->if_softc == struct arpcom/struct > ifnet. I'm not exactly sure how to deal with the miibus stuff at this > point; the following, in mii.c:miibus_linkchg(): > > mii = device_get_softc(dev); > ifp = device_get_softc(parent); > > can be changed to: > > mii = device_get_softc(dev); > ifp = mii->mii_ifp; > > I'm thinking we could pass struct ifnet in to mii.c:mii_phy_probe() and > attach it to the device ivars. > I would think that the latter makes the most sense. It all doesn't matter *too* much as long as what the requirements are are reasonably documented or known. -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message