Date: Sat, 22 Mar 2014 16:07:58 -0400 From: Nikolai Lifanov <lifanov@mail.lifanov.com> To: pawel@freebsd.org Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/187453: [maintainer] [update] [patch] sysutils/ansible 1.5.2 Message-ID: <20a5e4d5204aac941ab9a2e691a53313@mail.lifanov.com> In-Reply-To: <201403221930.s2MJUHa9022445@freefall.freebsd.org> References: <201403221930.s2MJUHa9022445@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-03-22 15:30, pawel@FreeBSD.org wrote: > Synopsis: [maintainer] [update] [patch] sysutils/ansible 1.5.2 > > State-Changed-From-To: open->feedback > State-Changed-By: pawel > State-Changed-When: Sat Mar 22 19:26:39 UTC 2014 > State-Changed-Why: > DIstfile size is wrong, please check contents of tarball for malicious > content. Same thing with 1.5.2, this is worrisome... > > ===> License GPLv3 accepted by the user ===> ansible-1.5.3 depends > on > file: /usr/local/sbin/pkg - found => ansible-1.5.3.tar.gz doesn't seem > to exist in /usr/ports/distfiles/. => Attempting to fetch > http://releases.ansible.com/ansible/ansible-1.5.3.tar.gz fetch: > http://releases.ansible.com/ansible/ansible-1.5.3.tar.gz: size > mismatch: > expected 542711, actual 542687 => Attempting to fetch > ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/ansible-1.5.3.tar.gz > fetch: > ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/ansible-1.5.3.tar.gz: > File unavailable (e.g., file not found, no access) => Couldn't fetch it > - please try to retrieve this => port manually into > /usr/ports/distfiles/ and try again. *** Error code 1 > > Stop. make: stopped in /home/corn/ansible > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=187453 I can confirm that *both* distfiles have been rerolled. The distfile for 1.5.2 has the same contents, compress ratio, archive size, etc. down to the letter, but the checksum doesn't match. For 1.5.3, there really is a difference: Index: ansible-1.5.3/library/packaging/apt_repository ================================================================== --- ansible-1.5.3/library/packaging/apt_repository +++ ansible-1.5.3/library/packaging/apt_repository @@ -351,13 +351,13 @@ def get_add_ppa_signing_key_callback(module): def _run_command(command): module.run_command(command, check_rc=True) if module.check_mode: - return _run_command + return None else: - return None + return _run_command def main(): module = AnsibleModule( argument_spec=dict( This is really terrible and happens all the time... I'm going to move away from the project download site and back to github snapshots... So, please hold for a new patch. - Nikolai Lifanov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20a5e4d5204aac941ab9a2e691a53313>