From owner-freebsd-hackers@FreeBSD.ORG  Mon Dec  1 06:19:41 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 34D891065675
	for <freebsd-hackers@freebsd.org>; Mon,  1 Dec 2008 06:19:41 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 12ED68FC24
	for <freebsd-hackers@freebsd.org>; Mon,  1 Dec 2008 06:19:41 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.123.2.178] (p53.kientzle.com [66.166.149.53])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id mB16Jetv097398;
	Sun, 30 Nov 2008 22:19:40 -0800 (PST)
	(envelope-from kientzle@freebsd.org)
Message-ID: <493381F7.4090301@freebsd.org>
Date: Sun, 30 Nov 2008 22:19:35 -0800
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Eitan Adler <eitanadlerlist@gmail.com>
References: <4931CB02.9070904@gmail.com> <4932E8CF.9040501@freebsd.org>
	<49334A62.7000800@gmail.com>
In-Reply-To: <49334A62.7000800@gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org
Subject: Re: keeping track of local modifications
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2008 06:19:41 -0000

>>* Search the source code for "TODO" or "XXX" to find
>>  comments ...
> 
> *slaps self for not thinking of this*
> Thanks for reminding me of this.  I'm now working on
>  * TODO: Make this better, so that "./a//b/./c/" == "a/b/c"
> part of src/usr.bin/tar/util.c
> I found a copy of abspath() in usr.sbin/pkg_install/info/perform.c
> This is the exact function needed to fix the TODO.
> 
> Where should I move the function to so that they could share it?  Should
>  I just copy the function (for some reason I doubt it)?
> realpath(3) is in sys/param.h and stdlib.h
> Should I move the function there?

Ah.  You picked one of mine.  <evil grin>

I'll follow up with you off-list.  ;-)

Tim