From owner-cvs-all Wed Nov 28 8: 5:42 2001 Delivered-To: cvs-all@freebsd.org Received: from lists.unixathome.org (lists.unixathome.org [210.48.103.158]) by hub.freebsd.org (Postfix) with ESMTP id 14CE537B41C; Wed, 28 Nov 2001 08:05:26 -0800 (PST) Received: from wocker (lists.unixathome.org [210.48.103.158]) by lists.unixathome.org (8.11.6/8.11.6) with ESMTP id fASG5J528461; Thu, 29 Nov 2001 05:05:20 +1300 (NZDT) (envelope-from dan@langille.org) From: "Dan Langille" Organization: novice in training To: Peter Wemm Date: Wed, 28 Nov 2001 11:05:16 -0500 MIME-Version: 1.0 Subject: Re: Meaningless commit messages [was: cvs commit: ports/www/linux-opera Makefile] Reply-To: dan@langille.org Cc: Maxim Sobolev , des@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <3C04C4EC.6878.178B76B6@localhost> References: <20011127163513.A12400@espresso.q9media.com> In-reply-to: <20011128110613.5E3073808@overcee.netplex.com.au> X-mailer: Pegasus Mail for Windows (v4.01) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 28 Nov 2001 at 3:06, Peter Wemm wrote: > Well, the guide is over simplifying it. Also, dont forget the previous > paragraph: > Good commit messages are important. They tell others > why you did the changes you did, not just right here and now, > but months or years from now when someone wonders why some > seemingly illogical or inefficient piece of code snuck into your > source file. It is also an invaluable aid to deciding which > changes to MFC and which not to MFC. A side note: One constant obstacle with guides is that from time to time people seek to find ways around them. Unless every possible situation is covered by the guide, people with find/exploit a loophole, frequently by quoting something in isolation. People should be working with the intent of the guidelines instead of the letter. Unfortunately, there are those that don't. It's for them that such changes are necessary. > I was planning to change the paragraph that you quoted to something like > this: > Commit messages should be clear, concise and provide > a reasonable summary to give an indication of what was > changed and why. > > Commit messages should provide enough information to > enable a third party to decide if the change is relevant to them > and if they need to read the change itself. If you are planning to change it, please consider my suggestions in http://docs.freebsd.org/cgi/getmsg.cgi?fetch=771838+0+current/cvs-all and I won't bother submitting a patch. thanks. -- Dan Langille The FreeBSD Diary - http://freebsddiary.org/ - practical examples To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message