Date: Thu, 11 Jul 2019 01:37:56 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Randall Stewart <rrs@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349907 - head/sys/netinet/tcp_stacks Message-ID: <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com> In-Reply-To: <201907110438.x6B4cXX1054795@repo.freebsd.org> References: <201907110438.x6B4cXX1054795@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jul 10, 2019, at 9:38 PM, Randall Stewart <rrs@freebsd.org> wrote: >=20 > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 >=20 > Log: > Update copyright per JBH's suggestions.. thanks. >=20 > Modified: > head/sys/netinet/tcp_stacks/rack.c >=20 > Modified: head/sys/netinet/tcp_stacks/rack.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 03:29:25 2019 = (r349906) > +++ head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 04:38:33 2019 = (r349907) > @@ -1,5 +1,5 @@ > /*- > - * Copyright (c) 2016 > + * Copyright (c) 2016-2019 > * Netflix Inc. All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -8537,10 +8537,10 @@ out: > * retransmit. In persist state, just set snd_max. > */ > if (error =3D=3D 0) { > -/* if (TCPS_HAVEESTABLISHED(tp->t_state) && > + if (TCPS_HAVEESTABLISHED(tp->t_state) && > (tp->t_flags & TF_SACK_PERMIT) && > tp->rcv_numsacks > 0) > - tcp_clean_dsack_blocks(tp);*/ > + tcp_clean_dsack_blocks(tp); Removing this commented out code unfortunately broke the build: = https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/12934/console = <https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/12934/console>; . Thanks, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6AC34953-52FC-48FC-B83F-CFFB6A48EC84>