From owner-freebsd-bugs@FreeBSD.ORG  Sat Mar 24 09:49:33 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0ABED16A401;
	Sat, 24 Mar 2007 09:49:33 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from smtp-1.dlr.de (smtp-1.dlr.de [195.37.61.185])
	by mx1.freebsd.org (Postfix) with ESMTP id 9960113C455;
	Sat, 24 Mar 2007 09:49:32 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from knop-beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-1.dlr.de
	over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); 
	Sat, 24 Mar 2007 10:37:27 +0100
Date: Sat, 24 Mar 2007 10:37:24 +0100 (CET)
From: Harti Brandt <hartmut.brandt@dlr.de>
X-X-Sender: brandt_h@knop-beagle.kn.op.dlr.de
To: freebsd-bugs@FreeBSD.org
In-Reply-To: <200703231844.l2NIiCsa089542@freefall.freebsd.org>
Message-ID: <20070324102948.Q58113@knop-beagle.kn.op.dlr.de>
References: <200703231844.l2NIiCsa089542@freefall.freebsd.org>
X-OpenPGP-Key: harti@freebsd.org
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-OriginalArrivalTime: 24 Mar 2007 09:37:27.0231 (UTC)
	FILETIME=[08EB64F0:01C76DF8]
Cc: freebsd-net@FreeBSD.org
Subject: Re: kern/110720: [net] [patch] support for interface descriptions
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Harti Brandt <harti@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Mar 2007 09:49:33 -0000


Nice feature, although it would be nice to align the maximum length with 
IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more 
naturally fits into struct if_data (see net/if.h) given the comment for 
that struct:

/*
 * Structure describing information about an interface
 * which may be of interest to management entities.
 */

harti