Date: Fri, 29 Oct 2004 10:09:33 +0800 From: Cheng-Lung Sung <clsung@FreeBSD.org> To: Kapranoff Alex <kappa@rambler-co.ru> Cc: Cheng-Lung Sung <clsung@FreeBSD.org> Subject: Re: ports/73235: New port devel/p5-Test-NoWarnings Message-ID: <20041029020933.GA29162@FreeBSD.csie.NCTU.edu.tw> In-Reply-To: <20041028142754.GA52244@capella.park.rambler.ru> References: <20041028134639.GA34561@FreeBSD.csie.NCTU.edu.tw> <20041028142754.GA52244@capella.park.rambler.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=big5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 28, 2004 at 06:27:54PM +0400, Kapranoff Alex wrote: > * Cheng-Lung Sung <clsung@FreeBSD.org> [October 28 2004, 17:46]: > > Hello,=20 > >=20 > > I'm testing your pr, there are two questions I don't understand. > >=20 > > 1. in build/install/deinstall section, I can't see any difference > > when set "INSTALL_TARGET=3D pure_install". Can you explain > > this to me? thanks. >=20 > `pure_install' disables writing anything into /usr/local/lib/perllocal.po= d, > and I strongly advocate for this feature. We never clean up perllocal, > so we'd better not clutter it. Newer Module::Build-based module > distributions do not bother with perllocal, it is obviously obsolete. >=20 > You can notice the difference watching the installation output, btw. > Normal `install' informs that it has written something to perllocal. This is a good lesson to me, I didn't notice about that before..... I found this will happen when perl ver < 5.8 (I didn't try in 5.005).= =20 However, I think it will do no harm even keep this simple. > > 2. in test phase (make test), I've noticed that Devel::StackTrace= =20 > > is eval(ed). Also in Warnings.pm. How about add this into=20 > > BUILD_DEPENDS? > Devel::StackTrace is optional really. The presence of this module at > run-time enables additional diagnostics from Test::NoWarnings but I > don't think the benefit justifies for a dependency. The user will > install it if she wants more diag, this is documented. You're right. > > Thank you for your works. > > By the way, ports/73237 (p5-Test-Deep) has the same issue (#1). >=20 > Thanks for quick response and all your, commiters crew, hard work :) Thank you. clsung --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBgaZc+AeJ85Vui8ERAvt8AJ9D1SV6imLzk9bAS/Fbvt3rFCcp8wCfVfN5 1KrVmiCU3oI9fBE4NT6ZvtA= =T2yA -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041029020933.GA29162>