Date: Wed, 20 Jul 2016 18:47:06 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Gleb Smirnoff <glebius@FreeBSD.org>, Randall Stewart <rrs@netflix.com> Cc: Randall Ray Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303037 - head/sys/kern Message-ID: <959a352e-f7a7-b578-2aaa-ab99281b6666@selasky.org> In-Reply-To: <20160720163501.GY1076@FreeBSD.org> References: <201607191831.u6JIVJWq007542@repo.freebsd.org> <20160720065335.GU1076@FreeBSD.org> <1CA02E0F-6871-4291-9F5A-20EFF5F6315D@netflix.com> <20160720163501.GY1076@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/20/16 18:35, Gleb Smirnoff wrote: > Randall, > > I have just tested and r303037 brings the TCP panic back. I > got two crashes during 2.5 hours. Hi Gleb, There is more than one way to fix the TCP panic. You don't _need_ to change the return values of callout_stop(). You _can_ make a new function for this, which doesn't cause problems in case anyone out there is depending on the current callout_stop() behaviour. > In your email [1] you are right, there is regression that (-1) > return value is lost. This problem was worked on in the PR 210884, > and we were very close to commiting the fix. > > The whole 11.0-RELEASE cycle strongly depends on this change. We > don't want to release with TCP panic, and of course we want the > regression described in 210884 to be fixed. > > Your backout mixed with extra code really made things messy. Since > I don't want to go with commit war, on behalf of RE we are asking > for explicit agreement to back out r303037. Then we will proceed with > latest patch from 210884. Is that okay? I think Randall is right trying to preserve the callout API. My wish Gleb, is that you add a new function to handle the new behaviour. > > [1] https://lists.freebsd.org/pipermail/svn-src-head/2016-July/089313.html > --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?959a352e-f7a7-b578-2aaa-ab99281b6666>