Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Oct 2005 11:51:35 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 85428 for review
Message-ID:  <200510171151.j9HBpZux054657@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=85428

Change 85428 by rwatson@rwatson_zoo on 2005/10/17 11:50:44

	KASSERT non-NULL argument to kaudit_to_bsm() rather than returning
	an error.
	
	kau_open() doesn't fail.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/kern_bsm_audit.c#21 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/kern_bsm_audit.c#21 (text+ko) ====

@@ -362,15 +362,11 @@
 	struct audit_record *ar;
 	int ctr;
 
+	KASSERT(kar != NULL, ("kaudit_to_bsm: kar == NULL"));
+
 	*pau = NULL;
-	if (kar == NULL)
-		return (BSM_FAILURE);
-
 	ar = &kar->k_ar;
-
 	rec = kau_open();
-	if (rec == NULL)
-		return (BSM_FAILURE);
 
 	/* Create the subject token */
 	tid.port = ar->ar_subj_term.port;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510171151.j9HBpZux054657>