From owner-svn-src-head@freebsd.org Wed Aug 17 14:49:54 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E53D3BBD75D; Wed, 17 Aug 2016 14:49:54 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9A51E1225; Wed, 17 Aug 2016 14:49:54 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1ba2A4-0002Qi-Sk; Wed, 17 Aug 2016 17:49:44 +0300 Date: Wed, 17 Aug 2016 17:49:44 +0300 From: Slawa Olhovchenkov To: Nathan Whitehorn Cc: Dag-Erling =?utf-8?B?U23DuHJncmF2?= , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit Message-ID: <20160817144944.GM22212@zxy.spb.ru> References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 14:49:55 -0000 On Wed, Aug 17, 2016 at 07:36:00AM -0700, Nathan Whitehorn wrote: > > Your contention that the installer does not make policy decisions is > > equally spurious. The installer makes many policy decisions, including > > the disk layout, the size of the swap partition, the name of the pool, > > the use of boot environments (which I dislike but am not allowed to > > override), the number of filesets and their mountpoints (which I also > > dislike and am not allowed to override either), etc. The Unix > > philosophy is to push such decisions up the stack, not down. The > > decision to align partitions on 4096-byte boundaries because we're not > > sure of the correct number but know for a fact that using a smaller > > number can have a huge impact on performance is the installer's to make. > > Those are all things that the operating system does not have defaults > for: there are no tools like, say, gpart or newfs that layout disks in > any even vaguely automated way, and so no tools that would ever have > defaults for, say, the size of a swap partition except for the > installer. As such, the defaults are quite properly in the installer. > This is quite different: there are many tools that care about disk > alignment (say, gpart) and, by default, use the GEOM stripesize. The > installer is, after this patch, overriding what was meant to be a > system-wide default. > > My concern is that pushing this into the installer means that newfs, > zfs, gpart, etc., which all look at the GEOM stripesize for preferred > alignment, will still have suboptimal behavior on systems affected by > your patch. If we identified which drivers are reporting the wrong > alignment, we could fix the whole system at a go by changing it there. > As it is, we now have inconsistent default behavior for partitions > between tools (the installer and sade will now use a different alignment > than gpart on whatever systems you were trying to fix here) and between > pre- and post-installation environments. In long term, prefered aligment is forsing 4k (or may be more): install system on 512b [mirror] disk aligment now may be need required replace disk to 4k aligment. For more flexsible in future now best chois is 4k or more.