Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2001 02:16:17 +0100 (CET)
From:      Cyrille Lefevre <clefevre@citeweb.net>
To:        Thierry Thomas <thierry@thomas.as>
Cc:        freebsd-ports@FreeBSD.org
Subject:   Re: ports/29286: New port: french/xtel - an emulator for the french Minitel
Message-ID:  <200111100116.fAA1GHo04726@gits.dyndns.org>
In-Reply-To: <200111092310.fA9NA2u70578@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Thierry Thomas wrote:
> The following reply was made to PR ports/29286; it has been noted by GNATS.
>  X+#if defined(__FreeBSD__)
>  X+FriBiINC = -I/usr/local/include -L/usr/local/lib
                  ^^^^^^^^^^           ^^^^^^^^^^
should be handled as %%LOCALBASE%% at (real)patch level then changed to
${LOCALBASE} at post-patch level. use something like :

PATCH_FILES= Imakefile
post-patch:
.for file in ${PATCH_FILES}
	@${PERL} -pi.fbsd -e 's.!!LOCALBASE!!.${LOCALBASE}.g' ${WRKSRC}/${file}
.endfir

IMHO, FriBiINC should be named EXTRA_INCLUDES.

>  X-      XTELCFLAGS = $(NETWORKCFLAGS) $(TERMIOCFLAGS) $(SELFILECFLAGS) $(LOWMCFLAGS) $(XPMCFLAGS) $(MOTIFCFLAGS) $(SYSLOGCFLAGS) $(TVRCFLAGS) $(WINCFLAGS) $(XTELDFLAGS) $(POPUPFLAGS)
>  X+      XTELCFLAGS = $(NETWORKCFLAGS) $(TERMIOCFLAGS) $(SELFILECFLAGS) $(LOWMCFLAGS) $(XPMCFLAGS) $(MOTIFCFLAGS) $(SYSLOGCFLAGS) $(TVRCFLAGS) $(WINCFLAGS) $(XTELDFLAGS) $(POPUPFLAGS) $(FriBiINC)

using EXTRA_INCLUDES, this shouldn't be necessary.

[snip]
>  Xpost-install:
>  X.if !defined(NOPORTDOCS)
>  X	${MKDIR} ${DOCSDIR}
>  X.for FILE in ${DOCS}
>  X	${INSTALL_DATA} ${WRKSRC}/${FILE} ${DOCSDIR}
>  X.endfor
>  X	@(if [ 0${LANGUE} = 0fr ] ; then \
>  X	${ECHO_MSG} "La documentation a été installée dans ${DOCSDIR}." ; \
>  X	else \
>  X	${ECHO_MSG} "Documentation installed in ${DOCSDIR}." ; \
>  X	fi)
>  X.endif
>  X	@${TOUCH} ${PREFIX}/lib/X11/xtel/xtel.log
>  X	@${ECHO} "*********************************************************************"
>  X	@(if [ 0${LANGUE} = 0fr ] ; then \
[snip]

hue! this is really bad. pkg-message or pkg-install are there to handle such
message... see patch-message and display-message targets in net/isc-dhcp3/\
Makefile to see how to handle well ${PREFIX} and such. you need to add
MSG_FILES and PKGMESSAGE variables to your Makefile and use
bsd.port.pre/port.mk include.

>  X	fi)
>  X	@${ECHO} "*********************************************************************"
>  X
>  X.include <bsd.port.mk>
>  END-of-/usr/ports/french/xtel/Makefile
[snip]
>  XWWW: http://www.com1.fr/~pficheux/xtel/
>  X
>  X- Thierry Thomas <thierry@thomas.as>.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I already object on putting Mailtainer informations in pkg-descr in the past.
I've submitted a patch a few weeks ago about that. see PR #31389 for details.

	http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/31389

>  END-of-/usr/ports/french/xtel/pkg-descr
[snip]
>  This remove the support of iminitel, beceause I am unable to maintain it.

why ?

Cyrille.
-- 
Cyrille Lefevre                 mailto:clefevre@citeweb.net

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111100116.fAA1GHo04726>