From owner-freebsd-ports Fri Nov 9 17:16:23 2001 Delivered-To: freebsd-ports@freebsd.org Received: from smtp.noos.fr (descartes.noos.net [212.198.2.74]) by hub.freebsd.org (Postfix) with ESMTP id AFFE737B41C for ; Fri, 9 Nov 2001 17:16:19 -0800 (PST) Received: (qmail 39621469 invoked by uid 0); 10 Nov 2001 01:16:18 -0000 Received: from unknown (HELO gits.dyndns.org) ([212.198.229.145]) (envelope-sender ) by 212.198.2.74 (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 10 Nov 2001 01:16:18 -0000 Received: (from root@localhost) by gits.dyndns.org (8.11.6/8.11.6) id fAA1GHo04726; Sat, 10 Nov 2001 02:16:17 +0100 (CET) (envelope-from root) Message-Id: <200111100116.fAA1GHo04726@gits.dyndns.org> Subject: Re: ports/29286: New port: french/xtel - an emulator for the french Minitel In-Reply-To: <200111092310.fA9NA2u70578@freefall.freebsd.org> To: Thierry Thomas Date: Sat, 10 Nov 2001 02:16:17 +0100 (CET) Cc: freebsd-ports@FreeBSD.org Reply-To: clefevre@citeweb.net From: Cyrille Lefevre Organization: ACME X-Face: X-Mailer: ELM [version 2.4ME+ PL95a (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Thierry Thomas wrote: > The following reply was made to PR ports/29286; it has been noted by GNATS. > X+#if defined(__FreeBSD__) > X+FriBiINC = -I/usr/local/include -L/usr/local/lib ^^^^^^^^^^ ^^^^^^^^^^ should be handled as %%LOCALBASE%% at (real)patch level then changed to ${LOCALBASE} at post-patch level. use something like : PATCH_FILES= Imakefile post-patch: .for file in ${PATCH_FILES} @${PERL} -pi.fbsd -e 's.!!LOCALBASE!!.${LOCALBASE}.g' ${WRKSRC}/${file} .endfir IMHO, FriBiINC should be named EXTRA_INCLUDES. > X- XTELCFLAGS = $(NETWORKCFLAGS) $(TERMIOCFLAGS) $(SELFILECFLAGS) $(LOWMCFLAGS) $(XPMCFLAGS) $(MOTIFCFLAGS) $(SYSLOGCFLAGS) $(TVRCFLAGS) $(WINCFLAGS) $(XTELDFLAGS) $(POPUPFLAGS) > X+ XTELCFLAGS = $(NETWORKCFLAGS) $(TERMIOCFLAGS) $(SELFILECFLAGS) $(LOWMCFLAGS) $(XPMCFLAGS) $(MOTIFCFLAGS) $(SYSLOGCFLAGS) $(TVRCFLAGS) $(WINCFLAGS) $(XTELDFLAGS) $(POPUPFLAGS) $(FriBiINC) using EXTRA_INCLUDES, this shouldn't be necessary. [snip] > Xpost-install: > X.if !defined(NOPORTDOCS) > X ${MKDIR} ${DOCSDIR} > X.for FILE in ${DOCS} > X ${INSTALL_DATA} ${WRKSRC}/${FILE} ${DOCSDIR} > X.endfor > X @(if [ 0${LANGUE} = 0fr ] ; then \ > X ${ECHO_MSG} "La documentation a été installée dans ${DOCSDIR}." ; \ > X else \ > X ${ECHO_MSG} "Documentation installed in ${DOCSDIR}." ; \ > X fi) > X.endif > X @${TOUCH} ${PREFIX}/lib/X11/xtel/xtel.log > X @${ECHO} "*********************************************************************" > X @(if [ 0${LANGUE} = 0fr ] ; then \ [snip] hue! this is really bad. pkg-message or pkg-install are there to handle such message... see patch-message and display-message targets in net/isc-dhcp3/\ Makefile to see how to handle well ${PREFIX} and such. you need to add MSG_FILES and PKGMESSAGE variables to your Makefile and use bsd.port.pre/port.mk include. > X fi) > X @${ECHO} "*********************************************************************" > X > X.include > END-of-/usr/ports/french/xtel/Makefile [snip] > XWWW: http://www.com1.fr/~pficheux/xtel/ > X > X- Thierry Thomas . ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I already object on putting Mailtainer informations in pkg-descr in the past. I've submitted a patch a few weeks ago about that. see PR #31389 for details. http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/31389 > END-of-/usr/ports/french/xtel/pkg-descr [snip] > This remove the support of iminitel, beceause I am unable to maintain it. why ? Cyrille. -- Cyrille Lefevre mailto:clefevre@citeweb.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message