From owner-freebsd-current  Fri Oct  1 16:19:40 1999
Delivered-To: freebsd-current@freebsd.org
Received: from feral.com (feral.com [192.67.166.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5D55514E01; Fri,  1 Oct 1999 16:19:38 -0700 (PDT)
	(envelope-from mjacob@feral.com)
Received: from beppo.feral.com (beppo [192.67.166.79])
	by feral.com (8.8.7/8.8.7) with ESMTP id QAA17998;
	Fri, 1 Oct 1999 16:16:43 -0700
Date: Fri, 1 Oct 1999 16:16:33 -0700 (PDT)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: mjacob@feral.com
To: Peter Wemm <peter@netplex.com.au>
Cc: phk@FreeBSD.ORG, current@FreeBSD.ORG
Subject: Re: BEWARE: CAM changes broke AHC!
In-Reply-To: <19991001220348.A90A71CA7@overcee.netplex.com.au>
Message-ID: <Pine.BSF.4.10.9910011615021.50024-100000@beppo.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


While I don't dispute that the change rolling/rollout fixed what you see,
I'd have to say that if they're related there are *far* more serious
problems in there.

> (da0:ahc0:0:0:0) data overrun detected in Data-In phase. Tag = 0x8
> (da0:ahc0:0:0:0) Have seen Data Phase.  Length = 0, NumSGs = 1
> 
> Backing out the following sys/cam/scsi change set:
> 
> revision 1.39
> date: 1999/10/01 09:34:09;  author: phk;  state: Exp;  lines: +47 -117
> Introduce the disk mini-layer and devstat_end_transaction_buf() in cam/scsi.
> 
> ..and the other files touched at the same time revived it and made the
> system bootable again.
> 
> I am particularly suspicious about this:
> 
> @@ -284,26 +283,14 @@
>                 return (error); /* error code from tsleep */
>         }
>  
> -       if ((softc->flags & DA_FLAG_OPEN) == 0) {
> -               if (cam_periph_acquire(periph) != CAM_REQ_CMP)
> -                       return(ENXIO);
> -               softc->flags |= DA_FLAG_OPEN;
> -       }
> +       if (cam_periph_acquire(periph) != CAM_REQ_CMP)
> +               return(ENXIO);
> +       softc->flags |= DA_FLAG_OPEN;
> 
> At first glance, it would appear it's re-inquiring on each open instead of
> the first open, including while it's mounted. I wasn't sure, so rather than
> risk disks, I backed the lot out and it worked again.
> 
> Cheers,
> -Peter
> 
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message