From owner-freebsd-bugs@FreeBSD.ORG Tue May 8 09:40:11 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEAB710656D0 for ; Tue, 8 May 2012 09:40:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AEE148FC1B for ; Tue, 8 May 2012 09:40:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q489eBMV084524 for ; Tue, 8 May 2012 09:40:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q489eBXk084523; Tue, 8 May 2012 09:40:11 GMT (envelope-from gnats) Date: Tue, 8 May 2012 09:40:11 GMT Message-Id: <201205080940.q489eBXk084523@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Adri Koppes" Cc: Subject: Re: kern/167357: [cc_htcp] cc_htcp(4) module sysctl variables overwritten X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adri Koppes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2012 09:40:11 -0000 The following reply was made to PR kern/167357; it has been noted by GNATS. From: "Adri Koppes" To: Cc: Subject: Re: kern/167357: [cc_htcp] cc_htcp(4) module sysctl variables overwritten Date: Tue, 8 May 2012 11:34:28 +0200 This is a multi-part message in MIME format. ------_=_NextPart_001_01CD2CFD.C3D6CF76 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The following patch fixes the problem: =20 --- cc_htcp.c.orig 2012-04-09 18:18:55.117275946 +0200 +++ cc_htcp.c 2012-05-08 11:21:14.513094522 +0200 @@ -168,8 +168,8 @@ static int htcp_max_diff =3D INT_MAX / ((1 << HTCP_ALPHA_INC_SHIFT) * = 10); /* Per-netstack vars. */ -static VNET_DEFINE(uint8_t, htcp_adaptive_backoff) =3D 0; -static VNET_DEFINE(uint8_t, htcp_rtt_scaling) =3D 0; +static VNET_DEFINE(u_int, htcp_adaptive_backoff) =3D 0; +static VNET_DEFINE(u_int, htcp_rtt_scaling) =3D 0; #define V_htcp_adaptive_backoff VNET(htcp_adaptive_backoff) #define V_htcp_rtt_scaling VNET(htcp_rtt_scaling) =20 =20 ------_=_NextPart_001_01CD2CFD.C3D6CF76 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

The following patch fixes the = problem:

--- = cc_htcp.c.orig = ; 2012-04-09 18:18:55.117275946 +0200

+++ cc_htcp.c 2012-05-08 = 11:21:14.513094522 +0200

@@ -168,8 +168,8 @@

static int htcp_max_diff =3D = INT_MAX / ((1 << HTCP_ALPHA_INC_SHIFT) * = 10);

/* = Per-netstack vars. */

-static VNET_DEFINE(uint8_t, htcp_adaptive_backoff) =3D = 0;

-static = VNET_DEFINE(uint8_t, htcp_rtt_scaling) =3D 0;

+static VNET_DEFINE(u_int, = htcp_adaptive_backoff) =3D 0;

+static VNET_DEFINE(u_int, = htcp_rtt_scaling) =3D 0;

= #define = V_htcp_adaptive_backoff = VNET(htcp_adaptive_backoff)

= #define = V_htcp_rtt_scaling = VNET(htcp_rtt_scaling)

------_=_NextPart_001_01CD2CFD.C3D6CF76--