Date: Sat, 12 Mar 2005 08:10:42 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c rijndael-alg-fst.h rijndael-api-fst.c rijndael-api-fst.h rijndael.h Message-ID: <yge4qfh6aod.wl%ume@mahoroba.org> In-Reply-To: <4231D748.4080405@errno.com> References: <200503111626.j2BGQAvL012546@repoman.freebsd.org> <4231D748.4080405@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, >>>>> On Fri, 11 Mar 2005 09:37:12 -0800 >>>>> Sam Leffler <sam@errno.com> said: sam> Why did you make this change and others before I could respond? I told sam> you I agreed with your overall goal but that there were specific isuses sam> we needed to resolve before you pulled the trigger. Less than 24 hours sam> after your last note to me you committed the changes. Sorry, I was too premature. sam> This change in particular I'm not happy with because--as I explained to sam> you--I am uncertain if there are user applications that include files sam> from /usr/include/crypto that may be affected. I changed to install crypto/rijndael/rijndael.h as /usr/include/crypto/rijndael.h. The difference from opencrypto/rijndael.h are: - export four internal functions. I realized it is required for gbde(8). - definitions of RIJNDAEL_MAXKC, RIJNDAEL_MAXKB and RIJNDAEL_MAXNR. These are correspond to MAXKC, MAXKB and MAXNR in opencrypto/rijndael.h. - rijndael_set_key() always sets up full context. opencrypto's one has a flag to set up context for encryption only. I confirmed that only gbde(8) refers rindael in src/sys, in our tree. Are you mind 3rd party application? sam> As we discussed privately there is no immediate benefit to what you are sam> doing. In fact because of these changes we are diverging from BOTH kame sam> and openbsd code bases. I'm willing to do that but only after sam> understanding the consequences. This integration will be done by moving opencrypto/* into crypto/. I think there is no conflict between opencrypto/ and crypto/, now. Can I go ahead? Or, once, should I backout my changes? Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yge4qfh6aod.wl%ume>