From owner-cvs-src@FreeBSD.ORG Fri Mar 11 23:10:56 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09D6B16A4CE; Fri, 11 Mar 2005 23:10:56 +0000 (GMT) Received: from cheer.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC96343D2F; Fri, 11 Mar 2005 23:10:54 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (ume@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)j2BNAgYV021071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 12 Mar 2005 08:10:43 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sat, 12 Mar 2005 08:10:42 +0900 Message-ID: From: Hajimu UMEMOTO To: Sam Leffler In-Reply-To: <4231D748.4080405@errno.com> References: <200503111626.j2BGQAvL012546@repoman.freebsd.org> <4231D748.4080405@errno.com> User-Agent: xcite1.38> Wanderlust/2.13.3 (You Oughta Know) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.0.50 (i386-unknown-freebsd5.4) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 5.4-PRERELEASE MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by milter-greylist-2.0b2 (cheer.mahoroba.org [IPv6:3ffe:501:185b:8010::1]); Sat, 12 Mar 2005 08:10:43 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, SUBJ_HAS_SPACES autolearn=ham version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on cheer.mahoroba.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c rijndael-alg-fst.h rijndael-api-fst.c rijndael-api-fst.h rijndael.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2005 23:10:56 -0000 Hi, >>>>> On Fri, 11 Mar 2005 09:37:12 -0800 >>>>> Sam Leffler said: sam> Why did you make this change and others before I could respond? I told sam> you I agreed with your overall goal but that there were specific isuses sam> we needed to resolve before you pulled the trigger. Less than 24 hours sam> after your last note to me you committed the changes. Sorry, I was too premature. sam> This change in particular I'm not happy with because--as I explained to sam> you--I am uncertain if there are user applications that include files sam> from /usr/include/crypto that may be affected. I changed to install crypto/rijndael/rijndael.h as /usr/include/crypto/rijndael.h. The difference from opencrypto/rijndael.h are: - export four internal functions. I realized it is required for gbde(8). - definitions of RIJNDAEL_MAXKC, RIJNDAEL_MAXKB and RIJNDAEL_MAXNR. These are correspond to MAXKC, MAXKB and MAXNR in opencrypto/rijndael.h. - rijndael_set_key() always sets up full context. opencrypto's one has a flag to set up context for encryption only. I confirmed that only gbde(8) refers rindael in src/sys, in our tree. Are you mind 3rd party application? sam> As we discussed privately there is no immediate benefit to what you are sam> doing. In fact because of these changes we are diverging from BOTH kame sam> and openbsd code bases. I'm willing to do that but only after sam> understanding the consequences. This integration will be done by moving opencrypto/* into crypto/. I think there is no conflict between opencrypto/ and crypto/, now. Can I go ahead? Or, once, should I backout my changes? Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/