From owner-freebsd-net@FreeBSD.ORG Wed Apr 7 01:19:11 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B66D1065672; Wed, 7 Apr 2010 01:19:11 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from mail-yx0-f175.google.com (mail-yx0-f175.google.com [209.85.210.175]) by mx1.freebsd.org (Postfix) with ESMTP id 6BC798FC0C; Wed, 7 Apr 2010 01:19:10 +0000 (UTC) Received: by yxe5 with SMTP id 5so282748yxe.3 for ; Tue, 06 Apr 2010 18:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:organization:x-operation-sytem; bh=jGGqRfTLKGMoygjmOIHsW6hfvJKj6xtMZdygVv8q8MI=; b=FxJrBCG+qiqucIyaQ8D/NsATCYEgRFTP3QN4o/Nlzol9aeDvAQ4mJqSPFYxr0TxovW NTSzDNDdI+2e7fpVUUFyOpkDaO6wcyAY00gK+UJdZsD/mBSEv1l3wdDqAGVVbAoH52H+ QPa38H1YDfbQ8wxsX46grngl04sik69zbiB90= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:organization:x-operation-sytem; b=FWhGD0qqBSZDLUB4DzHDV/3VsxU+XW61MgNcE4PZMeHNmA3TNubIhsroFJjtA7jA3k pEvzkT+4ozUZnaFkfl1TpYGiPkPjpHabvJnPeJRDfcFxncf2S0G35NKs5i+wZGk2sQpe q1BU+ZhcDpNJNwY2Y4W+OiRGLOR9mnVXul61o= Received: by 10.150.14.4 with SMTP id 4mr8925281ybn.116.1270603149424; Tue, 06 Apr 2010 18:19:09 -0700 (PDT) Received: from weongyo ([174.35.1.224]) by mx.google.com with ESMTPS id a1sm10849408ibs.0.2010.04.06.18.19.06 (version=SSLv3 cipher=RC4-MD5); Tue, 06 Apr 2010 18:19:07 -0700 (PDT) Received: by weongyo (sSMTP sendmail emulation); Tue, 6 Apr 2010 18:19:25 -0700 From: Weongyo Jeong Date: Tue, 6 Apr 2010 18:19:25 -0700 To: Rui Paulo Message-ID: <20100407011925.GC6799@weongyo> Mail-Followup-To: Rui Paulo , Sam Leffler , Andrew Thompson , Bernhard Schmidt , freebsd-net References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: freebsd-net , Andrew Thompson , Bernhard Schmidt Subject: Re: net80211 ratectl proof of concept X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2010 01:19:11 -0000 On Mon, Apr 05, 2010 at 05:54:20PM +0100, Rui Paulo wrote: > > On 31 Mar 2010, at 14:05, Rui Paulo wrote: > > > Hi, > > I've started developing a ratectl framework for net80211, loosely > > based on what DragonFly has. Right now only one driver has been > > ported, but I would like your feedback before continuing. > > > > The objective is to, eventually, have all the ratectl stuff (amrr, > > sample, onoe(?) and rssadapt) in net80211 so all drivers can use it. > > We can also select which ratectl modules are built in the kernel > > config file. > > The framework support changing the current ratectl is out of scope > > for this patch. > > > > You can find the patch here: > > * http://people.freebsd.org/~rpaulo/ratectl.diff > > > > Only the ral driver and the AMRR rate control algorithms were ported. > > > > Some comments: > > o The rate control calls now dereferences several pointers and some > > inline functions are now real functions. I wonder how much this > > impacts performance and what we can do to solve it. > > > > o I wished there was a better way to do the IEEE80211_AMRR_SUCCESS / > > IEEE80211_AMRR_FAILURe call. > > > > o Some other stuff can also be `const' > > > > o I create ieee80211_ratect.[ch] to avoid polluting other files > > > > o I moved the AMRR parameters inside amrr_init() on purpose. The > > drivers we have now only specify a different interval and I plan to > > add export amrr_set_interval() via the ratectl framework later. > > > > > > I would like very much to see this in, unless there's a strong > > impending argument. > > I've ported all the drivers but I can't test them all. You can read > the patch at the same URL. > > I would like to commit this soon, though. It looks it's what I really want to see. Please go forward. regards, Weongyo Jeong