From owner-freebsd-net@freebsd.org  Tue Jul 11 20:05:13 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65548DAB3B4
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Tue, 11 Jul 2017 20:05:13 +0000 (UTC)
 (envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 03AD865074
 for <freebsd-net@freebsd.org>; Tue, 11 Jul 2017 20:05:12 +0000 (UTC)
 (envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
 by alchemy.franken.de (8.15.2/8.15.2/ALCHEMY.FRANKEN.DE) with ESMTPS id
 v6BK5AYw077862
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 11 Jul 2017 22:05:10 +0200 (CEST)
 (envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
 by alchemy.franken.de (8.15.2/8.15.2/Submit) id v6BK5A4r077861;
 Tue, 11 Jul 2017 22:05:10 +0200 (CEST) (envelope-from marius)
Date: Tue, 11 Jul 2017 22:05:10 +0200
From: Marius Strobl <marius@freebsd.org>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: FreeBSD Net <freebsd-net@freebsd.org>
Subject: Re: NULL pointer dereference bug triggered by netmap
Message-ID: <20170711200510.GB60651@alchemy.franken.de>
References: <CA+_eA9goJ6j=q6UO-+fOt-aHVgFmujQfH8WfYEHf9=PQobdwHg@mail.gmail.com>
 <20170705110512.GA28058@alchemy.franken.de>
 <CA+_eA9h138BhHaeyEojzM3UFc__GWxV72uVSHCWVWw-6CbnGsw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+_eA9h138BhHaeyEojzM3UFc__GWxV72uVSHCWVWw-6CbnGsw@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2017 20:05:13 -0000

On Thu, Jul 06, 2017 at 02:19:42PM -0700, Vincenzo Maffione wrote:
> Sure, can anyone commit this?

The addition of KASSERTs like the below one to if_handoff() and
if_start()? Sure.

Marius

> 
> Il 5 lug 2017 4:05 AM, "Marius Strobl" <marius@freebsd.org> ha scritto:
> 
> > On Mon, Jul 03, 2017 at 05:08:09PM +0200, Vincenzo Maffione wrote:
> > > Details here:
> > >
> > > https://github.com/luigirizzo/netmap/issues/322
> > >
> > > Is it acceptable to commit the proposed patch?
> >
> > As suggested by hselasky@, the outliner problem at hand is better solved
> > by a dummy if_start method in order to not hurt the fast-path. Thus, if
> > anything at all, a KASSERT(ifp->if_start != NULL, "no if_start method")
> > should be added to if_handoff() and if_start().
> >