From owner-p4-projects Thu Jun 27 7:15:16 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F3BFE37B47A; Thu, 27 Jun 2002 07:14:52 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from holly.calldei.com (adsl-208-191-149-232.dsl.hstntx.swbell.net [208.191.149.232]) by hub.freebsd.org (Postfix) with ESMTP id C61D037B493; Thu, 27 Jun 2002 07:14:41 -0700 (PDT) Received: by holly.calldei.com (Postfix, from userid 1001) id 4F0EAA1C; Thu, 27 Jun 2002 09:14:59 -0500 (CDT) Date: Thu, 27 Jun 2002 09:14:58 -0500 From: Chris Costello To: Brian Feldman Cc: Perforce Change Reviews Subject: Re: PERFORCE change 13476 for review Message-ID: <20020627091458.C412@holly.calldei.com> Reply-To: chris@FreeBSD.org References: <200206271407.g5RE7djG050223@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200206271407.g5RE7djG050223@freefall.freebsd.org>; from green@FreeBSD.org on Thu, Jun 27, 2002 at 07:07:39AM -0700 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thursday, June 27, 2002, Brian Feldman wrote: > Don't crash if an ELF module is b0rked and has a 0 where it > shouldn't. Maybe I should just let it crash? More sanity/validity checks for KLD files is probably for the best. I can't see how you could go wrong in preventing an unnecessary crash, but I think printing a log message like "filename: Invalid ELF header" or the like would be a good idea as well. -- +-------------------+----------------------------------------------------+ | Chris Costello | Remember the good old days, when CPU was singular? | | chris@FreeBSD.org | | +-------------------+----------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message