From owner-freebsd-stable  Sat Jun  2 12:30:10 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from prism.flugsvamp.com (cb58709-a.mdsn1.wi.home.com [24.17.241.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6975C37B424; Sat,  2 Jun 2001 12:30:04 -0700 (PDT)
	(envelope-from jlemon@flugsvamp.com)
Received: (from jlemon@localhost)
	by prism.flugsvamp.com (8.11.0/8.11.0) id f52JS0C02501;
	Sat, 2 Jun 2001 14:28:00 -0500 (CDT)
	(envelope-from jlemon)
Date: Sat, 2 Jun 2001 14:28:00 -0500
From: Jonathan Lemon <jlemon@flugsvamp.com>
To: Kent Stewart <kstewart@urx.com>
Cc: Wilko Bulte <wkb@freebie.demon.nl>,
	Pete French <pfrench@firstcallgroup.co.uk>,
	freebsd-stable@freebsd.org, jlemon@freebsd.org
Subject: Re: Problem with xl driver (cvsup 2001-06-02)
Message-ID: <20010602142800.G82158@prism.flugsvamp.com>
References: <20010602173041.A15232@f113.hadiko.de> <E156E1q-000Ckv-00@dilbert.fcg.co.uk> <20010602185006.C7587@freebie.demon.nl> <3B193D2E.13A98AB3@urx.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0pre2i
In-Reply-To: <3B193D2E.13A98AB3@urx.com>
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

On Sat, Jun 02, 2001 at 12:23:26PM -0700, Kent Stewart wrote:
> On the 3C509-TX, the only thing that works so far is commenting out the
> write to the PHY, which is the one of the changes that Lemon made for the
> Intel card.
> 
> /*
>                 PHY_WRITE(sc, MII_NSPHY_PCR, reg);
>  */
> 
> I deleted the or's to reg until only setting the led was left and then I
> backed it all out and commented the PHY_WRITE, which restored networking to
> the NIC.
> 
> My system with a 3C509B-TX wasn't affected by the changes to mii/nsphy.c.


This is fairly useful to know.  The register definitions come from the
datasheet for the National part, so my guess is that the part used on
the 3C509 doesn't quite conform to the National specification.

Please try the following patch.  This should change things so that 
the register is only touched for the fxp card; otherwise it is left
alone.
-- 
Jonathan

Index: nsphy.c
===================================================================
RCS file: /ncvs/src/sys/dev/mii/nsphy.c,v
retrieving revision 1.8
diff -u -r1.8 nsphy.c
--- nsphy.c	2001/03/16 14:17:02	1.8
+++ nsphy.c	2001/06/02 19:28:34
@@ -276,7 +276,9 @@
 		 */
 		reg |= 0x0100 | 0x0400;
 
-		PHY_WRITE(sc, MII_NSPHY_PCR, reg);
+		if (strcmp(device_get_name(device_get_parent(sc->mii_dev)),
+		    "fxp") == 0)
+			PHY_WRITE(sc, MII_NSPHY_PCR, reg);
 
 		switch (IFM_SUBTYPE(ife->ifm_media)) {
 		case IFM_AUTO:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message