From owner-svn-src-head@freebsd.org Sun Nov 10 16:08:26 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 655071B7E06; Sun, 10 Nov 2019 16:08:26 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 479zSn2mXMz46j8; Sun, 10 Nov 2019 16:08:25 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr1-x441.google.com with SMTP id a15so12001183wrf.9; Sun, 10 Nov 2019 08:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=eht6eibHYoKmAU6t9ungnQD/lViJ8RY5t99Dhzoqcbg=; b=ltvQYtOB9fq6e9yDGYC0+FJ2FYx1hjhCXEoyZbP+482p3PYaIuP4PbkallgaLq6Zj8 R/4VZ9qiTV8GBEtyU0e7XllCZYlTTNFDnAGBa7FhLBjRx6dq48hm8EtSOGvA7RkeGZrg NhF11gUpt1Cosewy0T6+OKiM/R6yU17ywDJa1jtK5EpSfA8ojE4De1079B4QyE3IxIbn lN0GG4+bT8L37w1P6zFOX+RALW6fJVzFP7ZT8i9UFomfhBMSDctGP0JVkLOlPawp0LIb ippNj5vkinB6jiD1Rv/jSHff+BFosFGmYq8JuF6bQo66xenaz2LHi7e9XUr6hd4J0qdK qpuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=eht6eibHYoKmAU6t9ungnQD/lViJ8RY5t99Dhzoqcbg=; b=SY6t0FNGSVhPq/BWrcQUNP4RwbU8fkCsNuQAe8s70PmIydH6BlsYUN/ydCVp5cS0pd j5Dze/myWWc/AKnuCiEQl9H32Cfs0nJMVfsDkK5XGHndo1A7WLOud45JVnP4QSGgVjrA GUhAuAu0RR6hiJMyKAgvnbqeBlVoPXw1R8VfHA+gjbnrN2LXneb2OevM/SJWsey7FDkp 0N2Q7KWf+jhQAgO8fc9yEIvVs5nOgLefeXDwlCuZSG6QtSC7693+AunPKeo5fBiiHxw4 iac1+mWy/XR6tE+B/UJQuxf4RHXtVhT/lcasNET+71MsDTLGtrJPrWhBY3Lv5Vjj9R12 /k+Q== X-Gm-Message-State: APjAAAVubM24DtmoptyBZVn+ZDi7vLHc4BP565pYB4UFcZYoWbjDrzAw 3rSfR7r3BuFmqmnAtJ3hwicl+Sn1 X-Google-Smtp-Source: APXvYqwe8eHX2Ffizn9v+V3hx1+YY4z0TC7bN7LVCsSxIKD/fp+rCZn9ClCuVtnLb6QDRFXrMb0HzA== X-Received: by 2002:a05:6000:11c4:: with SMTP id i4mr16788691wrx.277.1573402103236; Sun, 10 Nov 2019 08:08:23 -0800 (PST) Received: from brick (cpc92302-cmbg19-2-0-cust461.5-4.cable.virginm.net. [82.1.209.206]) by smtp.gmail.com with ESMTPSA id c9sm11378411wmb.42.2019.11.10.08.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Nov 2019 08:08:22 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 10 Nov 2019 16:08:19 +0000 From: Edward Tomasz Napierala To: Alexander Leidinger Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354458 - head/libexec/rc/rc.d Message-ID: <20191110160819.GA1095@brick> Mail-Followup-To: Alexander Leidinger , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201911071815.xA7IFOhI070066@repo.freebsd.org> <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 479zSn2mXMz46j8 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ltvQYtOB; dmarc=none; spf=pass (mx1.freebsd.org: domain of etnapierala@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=etnapierala@gmail.com X-Spamd-Result: default: False [-2.14 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.44)[ip: (2.61), ipnet: 2a00:1450::/32(-2.75), asn: 15169(-2.00), country: US(-0.05)]; FORGED_SENDER(0.30)[trasz@freebsd.org,etnapierala@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[206.209.1.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[trasz@freebsd.org,etnapierala@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Nov 2019 16:08:26 -0000 On 1109T2049, Alexander Leidinger wrote: > Quoting Edward Tomasz Napierala (from Thu, 7 Nov > 2019 18:15:24 +0000 (UTC)): > > > Author: trasz > > Date: Thu Nov 7 18:15:24 2019 > > New Revision: 354458 > > URL: https://svnweb.freebsd.org/changeset/base/354458 > > > > Log: > > Extend the linux rc script to mount the neccessary file systems, > > set ELF fallback brand, and load pty(4). > > We never did something like that. We have it documented everywhere > that it needs to be done manually. So this is at least a POLA > violation. It is great that the nocover option is used in the mount, > but it's still some kind of layering violation (I may want to have > only a subset mounted, or nothing at all). It is kind of a POLA violation, but previously the linux_enable knob didn't do much apart from loading the linux{,64}.ko kernel module and doing something weird with ldconfig, which I'm not even sure is actually useful. In other words, the old behaviour can be restored by just not using linux_enable, and instead loading the kernel modules the same way all the others are loaded. Could you give me some use case why someone would want only a subset of the filesystems? > I do not object to the functionality, but I think it needs to be > configurable (an option to influence if the auto-mount is done or not, > doesn't matter to me what the default behavior is, as long as it is > configurable) and documented (UPDATING, handbook, man-pages, maybe > even the release notes). Man page updates are pending review at https://reviews.freebsd.org/D22277. Good point about the Handbook and release notes; I'll take a look.