Date: Sun, 30 Oct 2005 10:56:47 +0000 From: Ceri Davies <ceri@submonkey.net> To: David O'Brien <obrien@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/conf DEFAULTS GENERIC Message-ID: <20051030105647.GR99857@submonkey.net> In-Reply-To: <20051030062148.GA76667@dragon.NUXI.org> References: <200510271734.j9RHYZAk015054@repoman.freebsd.org> <20051030062148.GA76667@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--37cJpJlYZwAfNbm5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 29, 2005 at 11:21:48PM -0700, David O'Brien wrote: > On Thu, Oct 27, 2005 at 05:34:35PM +0000, John Baldwin wrote: > > jhb 2005-10-27 17:34:35 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/i386/conf GENERIC=20 > > Added files: > > sys/i386/conf DEFAULTS=20 > > Log: > > Create a default kernel config for i386 and move 'device isa' and > > 'device npx' (both of which aren't really optional right now) and > > 'device io' and 'device mem' (to preserve POLA for 4.x users upgrading > > to 6.0) from GENERIC into DEFAULTS. >=20 > I may be missing something. I don't quite follow the benefit of the new > 'DEFAULTS' file. I'm also curious why we don't explicitly 'include' > DEFAULTS in GENERIC vs. the new automagic include feature. I was also confused by that. There are also no warnings if DEFAULTS is missing, which means that by removing a seemingly unrelated file I get a different (read: useless to me) kernel. Does INCLUDE_CONFIG_FILE show the contents of DEFAULTS as well? Perhaps we can move to requiring an explicit "include" in -HEAD? This should alleviate most of my concerns (except the INCLUDE_CONFIG_FILE one). Ceri --=20 Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Einstein (attrib.) --37cJpJlYZwAfNbm5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDZKbvocfcwTS3JF8RAoLIAJ0eIZWdblSzyXUf5a42l1CkRWZpmgCfWYWu qxPB0rffqz1LQCTrSnSMw/4= =I4yK -----END PGP SIGNATURE----- --37cJpJlYZwAfNbm5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051030105647.GR99857>