From owner-freebsd-current@FreeBSD.ORG Fri Apr 11 05:17:37 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58D5037B401 for ; Fri, 11 Apr 2003 05:17:37 -0700 (PDT) Received: from mailspool.ops.uunet.co.za (mailspool.ops.uunet.co.za [196.7.0.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 444C043F75 for ; Fri, 11 Apr 2003 05:17:34 -0700 (PDT) (envelope-from ianf@wcom.com) Received: from copernicus.so.cpt1.za.uu.net ([196.30.72.32]) by mailspool.ops.uunet.co.za with esmtp (Exim 3.36 #1) id 193xTB-000JgC-00; Fri, 11 Apr 2003 14:17:25 +0200 Received: from localhost ([127.0.0.1] helo=wcom.com) by copernicus.so.cpt1.za.uu.net with esmtp (Exim 3.36 #1) id 193xT7-0000Am-00; Fri, 11 Apr 2003 14:17:21 +0200 To: Jeff Roberson In-reply-to: Your message of "Fri, 11 Apr 2003 00:08:29 -0400." <20030411000757.X37530-100000@mail.chesapeake.net> References: <20030411000757.X37530-100000@mail.chesapeake.net> From: "Ian Freislich" X-image-url: http://www.digs.iafrica.com/gallery/ian-small.gif X-BOFH: true X-LART: Depleted uranium X-No-Junk-Mail: I do not want to get *any* junk mail. You have been deleted Date: Fri, 11 Apr 2003 14:17:21 +0200 Message-ID: <667.1050063441@wcom.com> Sender: ianf@wcom.com cc: current@freebsd.org Subject: Re: ULE nice bugs are fixed. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2003 12:17:37 -0000 Jeff Roberson wrote: > Could those of you that have been testing it so far please try it out > again and let me know how it feels? ../../../kern/sched_ule.c: In function `sched_clock': ../../../kern/sched_ule.c:927: structure has no member named `ksq_rslice' $FreeBSD: src/sys/kern/sched_ule.c,v 1.22 2003/04/11 03:47:14 jeff Exp $ Is this the right version of the file? I don't know enough about the scheduler to be sure this is the right fix, but I suspect it should be kseq->ksq_rslices if the struct kseq definition is anything to go by. --- sched_ule.c.orig Fri Apr 11 12:10:56 2003 +++ sched_ule.c Fri Apr 11 11:45:02 2003 @@ -924,7 +924,7 @@ */ ke->ke_slice--; #ifdef SMP - kseq->ksq_rslice--; + kseq->ksq_rslices--; #endif if (ke->ke_slice > 0) It compiles after this change, but didn't come back after reboot. I'm no where near the machine at the moment, so I don't know why it hasn't come up. Ian