Date: Sun, 27 Dec 2009 20:11:04 +0100 From: Ed Schouten <ed@80386.nl> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200743 - in head/usr.sbin: . service Message-ID: <20091227191104.GZ64905@hoeg.nl> In-Reply-To: <200912200134.nBK1YCAA048942@svn.freebsd.org> References: <200912200134.nBK1YCAA048942@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--IbHvapklzsHS+ltG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Doug, Even though I think having a help-feature is nice, just expecting users to open up the proper manual page seems to be our tradition. Because of that, I think we should change the usage-output to conform a bit more with other applications. We should also display "-l | -r" instead of "-l|r". What do you think about the following patch? %%% Index: service.8 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- service.8 (revision 201047) +++ service.8 (working copy) @@ -35,7 +35,7 @@ .Fl e .Nm .Op Fl v -.Fl l|r +.Fl l | r .Nm .Op Fl v .Ar <rc.d script> start|stop|etc. Index: service.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- service.sh (revision 201047) +++ service.sh (working copy) @@ -30,24 +30,14 @@ load_rc_config 'XXX' =20 usage () { - echo '' - echo 'Usage:' - echo "${0##*/} -e" - echo "${0##*/} [-v] -l|r" - echo "${0##*/} [-v] <rc.d script> start|stop|etc." - echo "${0##*/} -h" - echo '' - echo '-e Show services that are enabled' - echo "-l List all scripts in /etc/rc.d and $local_startup" - echo '-r Show the results of boot time rcorder' - echo '-v Verbose' - echo '' + echo "usage: ${0##*/} -e" + echo " ${0##*/} [-v] -l | -r" + echo " ${0##*/} [-v] <rc.d script> start|stop|etc." } =20 while getopts 'ehlrv' COMMAND_LINE_ARGUMENT ; do case "${COMMAND_LINE_ARGUMENT}" in e) ENABLED=3Deopt ;; - h) usage ; exit 0 ;; l) LIST=3Dlopt ;; r) RCORDER=3Dropt ;; v) VERBOSE=3Dvopt ;; %%% --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --IbHvapklzsHS+ltG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAks3sUgACgkQ52SDGA2eCwW28wCeMXcYnGNXtpBA9jWVav/9OQJT Ga0An0LtWGAApweAuaDR1oDvqQ0VdQ1c =mB2X -----END PGP SIGNATURE----- --IbHvapklzsHS+ltG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091227191104.GZ64905>