Date: Thu, 05 Feb 2009 14:15:26 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Stefan Walter <stefan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/dkim-milter/files milter-dkim.sh.in Message-ID: <498B64FE.9080101@FreeBSD.org> In-Reply-To: <200902050840.n158eurh096951@repoman.freebsd.org> References: <200902050840.n158eurh096951@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Stefan Walter wrote: > stefan 2009-02-05 08:40:56 UTC > > FreeBSD ports repository > > Modified files: > mail/dkim-milter/files milter-dkim.sh.in > Log: > Fix a syntax error in the rc.d script. > > PR: 131161 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=131161 > Submitted by: "Ben C. O. Grimm" <freebsd@bengrimm.net> > > Revision Changes Path > 1.16 +2 -2 ports/mail/dkim-milter/files/milter-dkim.sh.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dkim-milter/files/milter-dkim.sh.in.diff?&r1=1.15&r2=1.16&f=h The milterdkim_flags default assignment is still wrong, it should be done as the _alg default is done above it. Also, it's not necessary to set empty defaults for anything except the _enable option. By default rc.d handles empty variables appropriately. hth, Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?498B64FE.9080101>